development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use a safe codec to read Skia SKP screenshot files when checking for errors (#14086)

Browse source 
If the downloaded file is an actual SKP and not an error report, then the
default UTF-8 codec will fail to decode the SKP content
This commit is contained in:
Jason Simmons 2018-01-12 17:54:49 -08:00 committed by GitHub
parent 27eeb9722f
commit e11cf5c94c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/flutter_tools/lib/src/commands/screenshot.dart
View file

@ -89,7 +89,9 @@ class ScreenshotCommand extends FlutterCommand {
await sink.close();
await showOutputFileInfo(outputFile);
if (await outputFile.length() < 1000) {
final String content = await outputFile.readAsString();
final String content = await outputFile.readAsString(
encoding: const AsciiCodec(allowInvalid: true),
);
if (content.startsWith('{"jsonrpc":"2.0", "error"'))
throwToolExit('\nIt appears the output file contains an error message, not valid skia output.');
}