development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 03:32:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

showOnScreen does not crash if target node doesn't exist anymore (#121575)

Browse source 
showOnScreen does not crash if target node doesn't exist anymore
This commit is contained in:
Michael Goderbauer 2023-02-27 19:06:28 -08:00 committed by GitHub
parent cd0030cc27
commit df66fecdcf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 49 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/flutter/lib/src/semantics/semantics.dart
View file

@ -3248,7 +3248,7 @@ class SemanticsOwner extends ChangeNotifier {
}
// Default actions if no [handler] was provided.
if (action == SemanticsAction.showOnScreen && _nodes[id]!._showOnScreen != null) {
if (action == SemanticsAction.showOnScreen && _nodes[id]?._showOnScreen != null) {
_nodes[id]!._showOnScreen!();
}
}

48
packages/flutter/test/semantics/semantics_owner_test.dart Normal file
View file

@ -0,0 +1,48 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter/material.dart';
import 'package:flutter/semantics.dart';
import 'package:flutter_test/flutter_test.dart';
import '../widgets/semantics_tester.dart';
void main() {
testWidgets('Performing SemanticsAction.showOnScreen does not crash if node no longer exist', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/100358.
final SemanticsTester semantics = SemanticsTester(tester);
addTearDown(semantics.dispose);
await tester.pumpWidget(
Directionality(
textDirection: TextDirection.ltr,
child: Semantics(
explicitChildNodes: true,
child: const Text('Hello World'),
),
),
);
final int nodeId = tester.semantics.find(find.bySemanticsLabel('Hello World')).id;
await tester.pumpWidget(
Directionality(
textDirection: TextDirection.ltr,
child: Container(),
),
);
// Node with $nodeId is no longer in the tree.
expect(semantics, isNot(hasSemantics(TestSemantics(id: nodeId))));
// Executing SemanticsAction.showOnScreen on that node does not crash.
// (A platform may not have processed the semantics update yet and send
// actions for no longer existing nodes.)
tester.binding.performSemanticsAction(SemanticsActionEvent(
type: SemanticsAction.showOnScreen,
nodeId: nodeId,
));
});
}