development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 19:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

PageView should be able to resize from zero (#8286)

Browse source 
When resizing a PageView from 0x0, we weren't sure what the old page
number was because all the pages are collapsed at zero. Now we avoid the
divide by zero and default to the initialPage.

Fixes #8285
This commit is contained in:
Adam Barth 2017-02-19 14:12:57 -08:00 committed by GitHub
parent 64bae978f1
commit df149c0b4b
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/flutter/lib/src/widgets/page_view.dart
View file

@ -86,7 +86,7 @@ class _PagePosition extends ScrollPosition {
final double oldViewportDimensions = this.viewportDimension;
final bool result = super.applyViewportDimension(viewportDimension);
final double oldPixels = pixels;
final double page = oldPixels == null ? initialPage.toDouble() : oldPixels / oldViewportDimensions;
final double page = (oldPixels == null || oldViewportDimensions == 0.0) ? initialPage.toDouble() : oldPixels / oldViewportDimensions;
final double newPixels = page * viewportDimension;
if (newPixels != oldPixels) {
correctPixels(newPixels);

12
packages/flutter/test/widgets/page_view_test.dart
View file

@ -204,5 +204,17 @@ void main() {
));
expect(find.text('Alabama'), findsOneWidget);
await tester.pumpWidget(new Center(
child: new SizedBox(
width: 200.0,
height: 200.0,
child: new PageView(
children: kStates.map<Widget>((String state) => new Text(state)).toList(),
),
),
));
expect(find.text('Alabama'), findsOneWidget);
});
}