development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup events related to material splashes

Browse source 
This CL is a warmup for using a more sophisticated gesture disambiguation.

1) Use gesturetap instead of click. We should probably remove click events
   because folks should use gesturetap to integrate with the gesture system.

2) Handle the case where you swipe the drawer during an animation. Previously
   we had an assert which triggered in some multitouch scenarios. We'll
   eventually move this over to gestureswipe.

3) Remove an extra container for ink splashes. There's no need to group all the
   ink splashes in a container. They can all just be children of the Material
   component itself. This structure is left over from when Material was a base
   class.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1013713005
This commit is contained in:
Adam Barth 2015-03-16 20:53:55 -07:00
parent 74cfcc4d39
commit de7f898442
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
examples/stocks-fn/stocksapp.dart
View file

@ -109,7 +109,7 @@ class StocksApp extends App {
new Icon(key: 'menu', style: _iconStyle,
size: 24,
type: 'navigation/menu_white')
..events.listen('click', _drawerAnimation.toggle),
..events.listen('gesturetap', _drawerAnimation.toggle),
new Container(
style: _titleStyle,
children: [title]
@ -117,7 +117,7 @@ class StocksApp extends App {
new Icon(key: 'search', style: _iconStyle,
size: 24,
type: 'action/search_white')
..events.listen('click', _handleSearchClick),
..events.listen('gesturetap', _handleSearchClick),
new Icon(key: 'more_white', style: _iconStyle,
size: 24,
type: 'navigation/more_vert_white')