development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Dont update last compiled time when compilation is rejected (#41424)" (#41515)

Browse source
This commit is contained in:
Jonah Williams 2019-09-27 15:18:06 -07:00 committed by GitHub
parent b9d8918bbb
commit d968b7cfd6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/flutter_tools/lib/src/devfs.dart
View file

@ -465,6 +465,7 @@ class DevFS {
generator.reset();
}
printTrace('Compiling dart to kernel with ${invalidatedFiles.length} updated files');
lastCompiled = DateTime.now();
final CompilerOutput compilerOutput = await generator.recompile(
mainPath,
invalidatedFiles,
@ -474,8 +475,6 @@ class DevFS {
if (compilerOutput == null || compilerOutput.errorCount > 0) {
return UpdateFSReport(success: false);
}
// Only update the last compiled time if we successfully compiled.
lastCompiled = DateTime.now();
// list of sources that needs to be monitored are in [compilerOutput.sources]
sources = compilerOutput.sources;
//

2
packages/flutter_tools/test/general.shard/devfs_test.dart
View file

@ -178,7 +178,6 @@ void main() {
testUsingContext('reports unsuccessful compile when errors are returned', () async {
devFS = DevFS(vmService, 'test', tempDir);
await devFS.create();
final DateTime previousCompile = devFS.lastCompiled;
final RealMockResidentCompiler residentCompiler = RealMockResidentCompiler();
when(residentCompiler.recompile(
@ -198,7 +197,6 @@ void main() {
);
expect(report.success, false);
expect(devFS.lastCompiled, previousCompile);
}, overrides: <Type, Generator>{
FileSystem: () => fs,
});