From d8b7eb6e2969a41ad705639c38c63d6aadf74760 Mon Sep 17 00:00:00 2001 From: Darren Austin Date: Wed, 14 Dec 2022 13:32:12 -0800 Subject: [PATCH] Updated token templates to sync with master code. (#117097) --- dev/tools/gen_defaults/lib/action_chip_template.dart | 2 +- dev/tools/gen_defaults/lib/filter_chip_template.dart | 2 +- dev/tools/gen_defaults/lib/input_chip_template.dart | 2 +- dev/tools/gen_defaults/lib/menu_template.dart | 5 ++++- dev/tools/gen_defaults/lib/time_picker_template.dart | 7 +++++-- packages/flutter/lib/src/material/time_picker.dart | 4 +--- 6 files changed, 13 insertions(+), 9 deletions(-) diff --git a/dev/tools/gen_defaults/lib/action_chip_template.dart b/dev/tools/gen_defaults/lib/action_chip_template.dart index 44d25692f77..1b130d633c7 100644 --- a/dev/tools/gen_defaults/lib/action_chip_template.dart +++ b/dev/tools/gen_defaults/lib/action_chip_template.dart @@ -72,7 +72,7 @@ class _${blockName}DefaultsM3 extends ChipThemeData { EdgeInsetsGeometry? get labelPadding => EdgeInsets.lerp( const EdgeInsets.symmetric(horizontal: 8.0), const EdgeInsets.symmetric(horizontal: 4.0), - clampDouble(MediaQuery.of(context).textScaleFactor - 1.0, 0.0, 1.0), + clampDouble(MediaQuery.textScaleFactorOf(context) - 1.0, 0.0, 1.0), )!; } '''; diff --git a/dev/tools/gen_defaults/lib/filter_chip_template.dart b/dev/tools/gen_defaults/lib/filter_chip_template.dart index 1f382d167a1..d532ca2607f 100644 --- a/dev/tools/gen_defaults/lib/filter_chip_template.dart +++ b/dev/tools/gen_defaults/lib/filter_chip_template.dart @@ -78,7 +78,7 @@ class _${blockName}DefaultsM3 extends ChipThemeData { EdgeInsetsGeometry? get labelPadding => EdgeInsets.lerp( const EdgeInsets.symmetric(horizontal: 8.0), const EdgeInsets.symmetric(horizontal: 4.0), - clampDouble(MediaQuery.of(context).textScaleFactor - 1.0, 0.0, 1.0), + clampDouble(MediaQuery.textScaleFactorOf(context) - 1.0, 0.0, 1.0), )!; } '''; diff --git a/dev/tools/gen_defaults/lib/input_chip_template.dart b/dev/tools/gen_defaults/lib/input_chip_template.dart index 2a4d3136ab9..45f713e82a4 100644 --- a/dev/tools/gen_defaults/lib/input_chip_template.dart +++ b/dev/tools/gen_defaults/lib/input_chip_template.dart @@ -71,7 +71,7 @@ class _${blockName}DefaultsM3 extends ChipThemeData { EdgeInsetsGeometry? get labelPadding => EdgeInsets.lerp( const EdgeInsets.symmetric(horizontal: 8.0), const EdgeInsets.symmetric(horizontal: 4.0), - clampDouble(MediaQuery.of(context).textScaleFactor - 1.0, 0.0, 1.0), + clampDouble(MediaQuery.textScaleFactorOf(context) - 1.0, 0.0, 1.0), )!; } '''; diff --git a/dev/tools/gen_defaults/lib/menu_template.dart b/dev/tools/gen_defaults/lib/menu_template.dart index ac61629060b..f62dccd5b41 100644 --- a/dev/tools/gen_defaults/lib/menu_template.dart +++ b/dev/tools/gen_defaults/lib/menu_template.dart @@ -18,6 +18,7 @@ class _MenuBarDefaultsM3 extends MenuStyle { shape: const MaterialStatePropertyAll(_defaultMenuBorder), alignment: AlignmentDirectional.bottomStart, ); + static const RoundedRectangleBorder _defaultMenuBorder = ${shape('md.comp.menu.container', '')}; @@ -60,6 +61,7 @@ class _MenuButtonDefaultsM3 extends ButtonStyle { enableFeedback: true, alignment: AlignmentDirectional.centerStart, ); + final BuildContext context; late final ColorScheme _colors = Theme.of(context).colorScheme; @@ -190,7 +192,7 @@ class _MenuButtonDefaultsM3 extends ButtonStyle { const EdgeInsets.symmetric(horizontal: 12), const EdgeInsets.symmetric(horizontal: 8), const EdgeInsets.symmetric(horizontal: 4), - MediaQuery.maybeOf(context)?.textScaleFactor ?? 1, + MediaQuery.maybeTextScaleFactorOf(context) ?? 1, ); } } @@ -202,6 +204,7 @@ class _MenuDefaultsM3 extends MenuStyle { shape: const MaterialStatePropertyAll(_defaultMenuBorder), alignment: AlignmentDirectional.topEnd, ); + static const RoundedRectangleBorder _defaultMenuBorder = ${shape('md.comp.menu.container', '')}; diff --git a/dev/tools/gen_defaults/lib/time_picker_template.dart b/dev/tools/gen_defaults/lib/time_picker_template.dart index ee15f185199..74027a26bf3 100644 --- a/dev/tools/gen_defaults/lib/time_picker_template.dart +++ b/dev/tools/gen_defaults/lib/time_picker_template.dart @@ -306,8 +306,11 @@ class _${blockName}DefaultsM3 extends _TimePickerDefaults { InputDecorationTheme get inputDecorationTheme { // This is NOT correct, but there's no token for // 'time-input.container.shape', so this is using the radius from the shape - // for the hour/minute selector. - final BorderRadiusGeometry selectorRadius = ${shape('$hourMinuteComponent.container')}.borderRadius; + // for the hour/minute selector. It's a BorderRadiusGeometry, so we have to + // resolve it before we can use it. + final BorderRadius selectorRadius = ${shape('$hourMinuteComponent.container')} + .borderRadius + .resolve(Directionality.of(context)); return InputDecorationTheme( contentPadding: EdgeInsets.zero, filled: true, diff --git a/packages/flutter/lib/src/material/time_picker.dart b/packages/flutter/lib/src/material/time_picker.dart index d12ffe82fd2..a041beaab6c 100644 --- a/packages/flutter/lib/src/material/time_picker.dart +++ b/packages/flutter/lib/src/material/time_picker.dart @@ -3684,9 +3684,7 @@ class _TimePickerDefaultsM3 extends _TimePickerDefaults { // 'time-input.container.shape', so this is using the radius from the shape // for the hour/minute selector. It's a BorderRadiusGeometry, so we have to // resolve it before we can use it. - final BorderRadius selectorRadius = const RoundedRectangleBorder( - borderRadius: BorderRadius.all(Radius.circular(8.0)), - ) + final BorderRadius selectorRadius = const RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(8.0))) .borderRadius .resolve(Directionality.of(context)); return InputDecorationTheme(