development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix integration hot-reload test on mac. (#21741)

Browse source 
Underlying issue with breakpoint was that /var path is a symlink to a /private/var on mac. Because of that breakpoint could not be resolved.
This commit is contained in:
Alexander Aprelev 2018-09-12 22:35:21 -07:00 committed by GitHub
parent 23499f4004
commit d61b48b75d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/flutter_tools/test/integration/hot_reload_test.dart
View file

@ -49,10 +49,6 @@ void main() {
Uri.file(_project.breakpointFile).toString(),
_project.breakpointLine);
expect(isolate.pauseEvent, isInstanceOf<VMPauseBreakpointEvent>());
// TODO(dantup): Unskip for Mac when [1] is fixed.
// [1] hot reload/breakpoints fail when uris prefixed with file://
// https://github.com/flutter/flutter/issues/18441
}, skip: !platform.isLinux && !platform.isWindows);
});
}, timeout: const Timeout.factor(6));
}

3
packages/flutter_tools/test/integration/test_data/test_project.dart
View file

@ -16,7 +16,8 @@ abstract class TestProject {
String get main;
// Valid locations for a breakpoint for tests that just need to break somewhere.
String get breakpointFile => fs.path.join(dir.path, 'lib', 'main.dart');
String get breakpointFile => fs.file(fs.path.join(
dir.path, 'lib', 'main.dart')).resolveSymbolicLinksSync();
int get breakpointLine => lineContaining(main, '// BREAKPOINT');
Future<void> setUpIn(Directory dir) async {