development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove TODO that's done (#44318)

Browse source 
See https://github.com/flutter/engine/pull/13728
This commit is contained in:
liyuqian 2019-11-07 14:06:07 -08:00 committed by GitHub
parent 2eb8caf13c
commit cc9e9ce2ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/flutter/lib/src/scheduler/binding.dart
View file

@ -224,9 +224,6 @@ mixin SchedulerBinding on BindingBase, ServicesBinding {
///
/// If the same callback is added twice, it will be executed twice.
void addTimingsCallback(TimingsCallback callback) {
// TODO(liyuqian): once this is merged, modify the doc of
// [Window.onReportTimings] inside the engine repo to recommend using this
// API instead of using [Window.onReportTimings] directly.
_timingsCallbacks.add(callback);
if (_timingsCallbacks.length == 1) {
assert(window.onReportTimings == null);