development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-09-21 17:22:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Run test harness finalizers in reverse order. (#16664)

Browse source 
Finalizers handle the restoration of state. In order to restore
the state correctly, they shouyld be run in LIFO order.

Fixes #16657
This commit is contained in:
Todd Volkert 2018-04-17 07:38:30 -07:00 committed by GitHub
parent 10cf0cedad
commit c7df2619d7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/flutter_tools/lib/src/test/flutter_platform.dart
View file

@ -275,7 +275,7 @@ class _FlutterPlatform extends PlatformPlugin {
dynamic outOfBandError; // error that we couldn't send to the harness that we need to send via our future
final List<_Finalizer> finalizers = <_Finalizer>[];
final List<_Finalizer> finalizers = <_Finalizer>[]; // Will be run in reverse order.
bool subprocessActive = false;
bool controllerSinkClosed = false;
try {
@ -511,7 +511,8 @@ class _FlutterPlatform extends PlatformPlugin {
}
} finally {
printTrace('test $ourTestCount: cleaning up...');
for (_Finalizer finalizer in finalizers) {
// Finalizers are treated like a stack; run them in reverse order.
for (_Finalizer finalizer in finalizers.reversed) {
try {
await finalizer();
} catch (error, stack) {