mirror of
https://github.com/flutter/flutter
synced 2024-08-24 18:36:03 +00:00
Update leak related TODOs. (#146743)
https://github.com/flutter/flutter/issues/146742
This commit is contained in:
parent
882bcbb9aa
commit
c4a7cf202a
|
@ -79,7 +79,7 @@ void main() {
|
|||
}, skip: true); // Typically skip: isBrowser https://github.com/flutter/flutter/issues/42767
|
||||
|
||||
testWidgets('Should show event indicator for pointer events with setSurfaceSize',
|
||||
// TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787 [leaks-to-clean]
|
||||
// TODO(polina-c): root layer is leaking, https://github.com/flutter/flutter/issues/146742 [leaks-to-clean]
|
||||
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
|
||||
(WidgetTester tester) async {
|
||||
final AnimationSheetBuilder animationSheet = AnimationSheetBuilder(frameSize: const Size(200, 200), allLayers: true);
|
||||
|
|
|
@ -831,8 +831,6 @@ void main() {
|
|||
|
||||
testWidgets('A controller can control more than one CupertinoTabScaffold, '
|
||||
'removal of listeners does not break the controller',
|
||||
// TODO(polina-c): dispose TabController, https://github.com/flutter/flutter/issues/144910 [leaks-to-clean]
|
||||
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
|
||||
(WidgetTester tester) async {
|
||||
final List<int> tabsPainted0 = <int>[];
|
||||
final List<int> tabsPainted1 = <int>[];
|
||||
|
@ -1277,10 +1275,7 @@ void main() {
|
|||
.setMockMethodCallHandler(SystemChannels.platform, null);
|
||||
});
|
||||
|
||||
testWidgets('System back navigation inside of tabs',
|
||||
// TODO(polina-c): dispose TabController, https://github.com/flutter/flutter/issues/144910
|
||||
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
|
||||
(WidgetTester tester) async {
|
||||
testWidgets('System back navigation inside of tabs', (WidgetTester tester) async {
|
||||
await tester.pumpWidget(
|
||||
CupertinoApp(
|
||||
home: MediaQuery(
|
||||
|
|
|
@ -14,7 +14,6 @@ import 'package:flutter/material.dart';
|
|||
import 'package:flutter/rendering.dart';
|
||||
import 'package:flutter/services.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
|
||||
|
||||
import 'semantics_tester.dart';
|
||||
|
||||
|
@ -2541,10 +2540,7 @@ void main() {
|
|||
});
|
||||
|
||||
// Regression test for https://github.com/flutter/flutter/issues/6128.
|
||||
testWidgets('Draggable plays nice with onTap',
|
||||
// TODO(polina-c): fix the leaking ImmediateMultiDragGestureRecognizer https://github.com/flutter/flutter/pull/144396 [leaks-to-clean]
|
||||
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
|
||||
(WidgetTester tester) async {
|
||||
testWidgets('Draggable plays nice with onTap', (WidgetTester tester) async {
|
||||
late final OverlayEntry entry;
|
||||
addTearDown(() => entry..remove()..dispose());
|
||||
|
||||
|
@ -2578,6 +2574,7 @@ void main() {
|
|||
|
||||
await firstGesture.moveBy(const Offset(100.0, 0.0));
|
||||
await secondGesture.up();
|
||||
await firstGesture.up();
|
||||
});
|
||||
|
||||
testWidgets('DragTarget does not set state when remove from the tree', (WidgetTester tester) async {
|
||||
|
@ -3434,10 +3431,7 @@ void main() {
|
|||
});
|
||||
|
||||
// Regression test for https://github.com/flutter/flutter/issues/92083
|
||||
testWidgets('feedback respect the MouseRegion cursor configure',
|
||||
// TODO(polina-c): fix the leaking ImmediateMultiDragGestureRecognizer https://github.com/flutter/flutter/pull/144396 [leaks-to-clean]
|
||||
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
|
||||
(WidgetTester tester) async {
|
||||
testWidgets('feedback respect the MouseRegion cursor configure', (WidgetTester tester) async {
|
||||
await tester.pumpWidget(
|
||||
const MaterialApp(
|
||||
home: Column(
|
||||
|
@ -3463,6 +3457,7 @@ void main() {
|
|||
await tester.pump();
|
||||
|
||||
expect(RendererBinding.instance.mouseTracker.debugDeviceActiveCursor(1), SystemMouseCursors.grabbing);
|
||||
gesture.up();
|
||||
});
|
||||
|
||||
testWidgets('configurable feedback ignore pointer behavior', (WidgetTester tester) async {
|
||||
|
|
|
@ -824,7 +824,7 @@ void main() {
|
|||
});
|
||||
|
||||
testWidgets('Precache removes original listener immediately after future completes, does not crash on successive calls #25143',
|
||||
// TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787 [leaks-to-clean]
|
||||
// TODO(polina-c): dispose ImageStreamCompleterHandle, https://github.com/flutter/flutter/issues/145599 [leaks-to-clean]
|
||||
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
|
||||
(WidgetTester tester) async {
|
||||
final _TestImageStreamCompleter imageStreamCompleter = _TestImageStreamCompleter();
|
||||
|
|
|
@ -10,7 +10,6 @@ import 'dart:io';
|
|||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter/semantics.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
|
||||
|
||||
import 'semantics_tester.dart';
|
||||
|
||||
|
@ -53,10 +52,7 @@ void _tests() {
|
|||
// also update this code to reflect the new output.
|
||||
//
|
||||
// This test is flexible w.r.t. leading and trailing whitespace.
|
||||
testWidgets('generates code',
|
||||
// TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787 [leaks-to-clean]
|
||||
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
|
||||
(WidgetTester tester) async {
|
||||
testWidgets('generates code', (WidgetTester tester) async {
|
||||
final SemanticsTester semantics = SemanticsTester(tester);
|
||||
await pumpTestWidget(tester);
|
||||
final String code = semantics
|
||||
|
|
|
@ -19,7 +19,7 @@ Future<void> main() async {
|
|||
final ImageProvider image = TestImageProvider(0, 0, image: rawImage);
|
||||
|
||||
testWidgets('ShapeDecoration.image',
|
||||
// TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787 [leaks-to-clean]
|
||||
// TODO(polina-c): dispose ImageStreamCompleterHandle, https://github.com/flutter/flutter/issues/145599 [leaks-to-clean]
|
||||
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
|
||||
(WidgetTester tester) async {
|
||||
await tester.pumpWidget(
|
||||
|
|
|
@ -346,8 +346,7 @@ void main() {
|
|||
});
|
||||
|
||||
testWidgets('correctly switches between view configurations',
|
||||
// TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787 [leaks-to-clean]
|
||||
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
|
||||
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(), // Leaking by design as contains deprecated items.
|
||||
(WidgetTester tester) async {
|
||||
await tester.pumpWidget(
|
||||
wrapWithView: false,
|
||||
|
|
Loading…
Reference in a new issue