development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-09-20 08:42:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle uncaught error for warnIfSlow (#56418)

Browse source
This commit is contained in:
Jia Hao 2020-05-06 23:16:03 +08:00 committed by GitHub
parent 6f0ed5e142
commit c2b7342ca4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/flutter_driver/lib/src/driver/vmservice_driver.dart
View file

@ -633,7 +633,15 @@ Future<T> _warnIfSlow<T>({
assert(future != null);
assert(timeout != null);
assert(message != null);
return future..timeout(timeout, onTimeout: () { _log(message); return null; });
future
.timeout(timeout, onTimeout: () {
_log(message);
return null;
})
// Don't duplicate errors if [future] completes with an error.
.catchError((dynamic e) => null);
return future;
}
/// Encapsulates connection information to an instance of a Flutter application.

10
packages/flutter_driver/test/flutter_driver_test.dart
View file

@ -665,6 +665,16 @@ void main() {
expect(error.message, 'Error in Flutter application: {message: This is a failure}');
}
});
test('uncaught remote error', () async {
when(mockIsolate.invokeExtension(any, any)).thenAnswer((Invocation i) {
return Future<Map<String, dynamic>>.error(
rpc.RpcException(9999, 'test error'),
);
});
expect(driver.waitFor(find.byTooltip('foo')), throwsDriverError);
});
});
});