development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 19:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

dont' validate against webstorm (#10828)

Browse source
This commit is contained in:
Devon Carew 2017-06-20 06:46:43 -07:00 committed by GitHub
parent 409414265e
commit c14470e0c7
1 changed files with 2 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
packages/flutter_tools/lib/src/doctor.dart
View file

@ -251,11 +251,9 @@ abstract class IntelliJValidator extends DoctorValidator {
static final Map<String, String> _idToTitle = <String, String>{
'IntelliJIdea' : 'IntelliJ IDEA Ultimate Edition',
'IdeaIC' : 'IntelliJ IDEA Community Edition',
'WebStorm': 'WebStorm',
};
static final Version kMinIdeaVersion = new Version(2017, 1, 0);
static final Version kMinWebStormVersion = new Version(2017, 1, 0);
static final Version kMinFlutterPluginVersion = new Version(14, 0, 0);
static Iterable<DoctorValidator> get installedValidators {
@ -272,11 +270,7 @@ abstract class IntelliJValidator extends DoctorValidator {
_validatePackage(messages, 'flutter-intellij.jar', 'Flutter',
minVersion: kMinFlutterPluginVersion);
// Dart is bundled with WebStorm.
if (!isWebStorm) {
_validatePackage(messages, 'Dart', 'Dart');
}
_validatePackage(messages, 'Dart', 'Dart');
if (_hasIssues(messages)) {
messages.add(new ValidationMessage(
@ -285,7 +279,7 @@ abstract class IntelliJValidator extends DoctorValidator {
));
}
_validateIntelliJVersion(messages, isWebStorm ? kMinWebStormVersion : kMinIdeaVersion);
_validateIntelliJVersion(messages, kMinIdeaVersion);
return new ValidationResult(
_hasIssues(messages) ? ValidationType.partial : ValidationType.installed,
@ -298,8 +292,6 @@ abstract class IntelliJValidator extends DoctorValidator {
return messages.any((ValidationMessage message) => message.isError);
}
bool get isWebStorm => title == 'WebStorm';
void _validateIntelliJVersion(List<ValidationMessage> messages, Version minVersion) {
// Ignore unknown versions.
if (minVersion == Version.unknown)
@ -429,7 +421,6 @@ class IntelliJValidatorOnMac extends IntelliJValidator {
'IntelliJ IDEA.app' : 'IntelliJIdea',
'IntelliJ IDEA Ultimate.app' : 'IntelliJIdea',
'IntelliJ IDEA CE.app' : 'IdeaIC',
'WebStorm.app': 'WebStorm',
};
static Iterable<DoctorValidator> get installed {