development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-01 05:54:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

[devicelab] Add hot reload tests to presubmit (#93684)

Browse source
This commit is contained in:
Casey Hillers 2021-11-30 17:29:06 -08:00 committed by GitHub
parent eb00598bec
commit c0da416482
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
.ci.yaml
View file

@ -1705,12 +1705,13 @@ targets:
- name: Linux_android hot_mode_dev_cycle_linux__benchmark
recipe: devicelab/devicelab_drone
presubmit: false
timeout: 60
properties:
tags: >
["devicelab","android","linux"]
task_name: hot_mode_dev_cycle_linux__benchmark
runIf:
- dev/**
scheduler: luci
- name: Linux_android image_list_jit_reported_duration
@ -3168,12 +3169,13 @@ targets:
- name: Mac_ios hot_mode_dev_cycle_macos_target__benchmark
recipe: devicelab/devicelab_drone
presubmit: false
timeout: 60
properties:
tags: >
["devicelab","ios","mac"]
task_name: hot_mode_dev_cycle_macos_target__benchmark
runIf:
- dev/**
scheduler: luci
- name: Mac_ios integration_test_test_ios

27
dev/devicelab/README.md
View file

@ -206,27 +206,14 @@ There are several PRs needed to add a DeviceLab task to CI.
_TASK_- the name of your test that also matches the name of the
file in `bin/tasks` without the `.dart` extension.
1. Add prod builder to [flutter/infra devicelab_config.star](https://github.com/flutter/infra/blob/master/config/devicelab_config.star)
- Example PR: https://github.com/flutter/infra/pull/401/files
- This will need to soak for 15 minutes after merged to propagate (should show up in [LUCI console](https://ci.chromium.org/p/flutter/g/devicelab/console))
- There are various lists for the different testbeds a test can run on
2. Add task to [flutter/flutter prod_builders.json](https://github.com/flutter/flutter/blob/master/dev/prod_builders.json)
- Example PR: https://github.com/flutter/flutter/pull/79913/files
- Set `flaky: true` for validation before blocking tree
3. After 10 green runs, update [flutter/flutter prod_builders.json](https://github.com/flutter/flutter/blob/master/dev/prod_builders.json) to `flaky:false`
1. Add target to
[.ci.yaml](https://github.com/flutter/flutter/blob/master/.ci.yaml)
- Mirror an existing one that has the recipe `devicelab_drone`
If your test needs to run on multiple operating systems, create a separate test
for each operating system.
If your test needs to run on multiple operating systems, create a separate
target for each operating system.
## Adding tests to presubmit
Flutter's DeviceLab does not currently have capacity to run tests against physical devices in presubmit.
Note that DeviceLab tests should generally require a tethered device. If you are adding host-only tests, considering adding your test to `packages/flutter_tools/test/integration.shard`. Example: https://github.com/flutter/flutter/pull/73577/files"
1. Add try builder to [flutter/infra devicelab_config.star](https://github.com/flutter/infra/blob/master/config/devicelab_config.star)
- Example PR: https://github.com/flutter/infra/pull/401/files
- This will need to soak for 15 minutes after merged to propagate
- There are various lists for the different testbeds a test can run on
2. Add task to [flutter/flutter try_builders.json](https://github.com/flutter/flutter/blob/master/dev/try_builders.json)
- Example PR: https://github.com/flutter/flutter/pull/79913/files
Flutter's DeviceLab has a limited capacity in presubmit. File an infra ticket
to investigate feasibility of adding a test to presubmit.