development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 03:32:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable vm:notify-debugger-on-exception for LayoutBuilder (#82835)

Browse source
This commit is contained in:
Michael Goderbauer 2021-05-21 18:39:13 -07:00 committed by GitHub
parent 0d79013a81
commit c04f0a2b69
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/flutter/lib/src/widgets/layout_builder.dart
View file

@ -115,11 +115,8 @@ class _LayoutBuilderElement<ConstraintType extends Constraints> extends RenderOb
} }
void _layout(ConstraintType constraints) { void _layout(ConstraintType constraints) {
// TODO(goderbauer): When https://github.com/dart-lang/sdk/issues/45710 is @pragma('vm:notify-debugger-on-exception')
// fixed: refactor the anonymous closure below into a named one, apply the void layoutCallback() {
// @pragma('vm:notify-debugger-on-exception') to it and enable the
// corresponding test in break_on_framework_exceptions_test.dart.
owner!.buildScope(this, () {
Widget built; Widget built;
try { try {
built = widget.builder(this, constraints); built = widget.builder(this, constraints);
@ -152,7 +149,9 @@ class _LayoutBuilderElement<ConstraintType extends Constraints> extends RenderOb
); );
_child = updateChild(null, built, slot); _child = updateChild(null, built, slot);
} }
}); }
owner!.buildScope(this, layoutCallback);
} }
@override @override

2
packages/flutter_tools/test/integration.shard/break_on_framework_exceptions_test.dart
View file

@ -388,7 +388,7 @@ void main() {
final int breakLine = (await flutter.getSourceLocation()).line; final int breakLine = (await flutter.getSourceLocation()).line;
expect(breakLine, project.lineContaining(project.test, "throw 'LayoutBuilder.builder';")); expect(breakLine, project.lineContaining(project.test, "throw 'LayoutBuilder.builder';"));
}, skip: 'TODO(goderbauer): Once https://github.com/dart-lang/sdk/issues/45710 is fixed, fix TODO in _LayoutBuilderElement._layout and enable this test'); });
testWithoutContext('breaks when _CallbackHookProvider callback throws', () async { testWithoutContext('breaks when _CallbackHookProvider callback throws', () async {
final TestProject project = TestProject( final TestProject project = TestProject(