From bc43b41d99a01bec523548cec3c10df7baa604ea Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Mon, 9 Mar 2020 17:19:14 -0700 Subject: [PATCH] [flutter_tools] ensure --track-widget-creation is not enabled for build aot (#52261) This option was defaulting to on, which was tickling some benchmarks --- packages/flutter_tools/lib/src/commands/build.dart | 2 +- packages/flutter_tools/lib/src/commands/build_aot.dart | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/flutter_tools/lib/src/commands/build.dart b/packages/flutter_tools/lib/src/commands/build.dart index 26c43f68935..3a7cbaeb545 100644 --- a/packages/flutter_tools/lib/src/commands/build.dart +++ b/packages/flutter_tools/lib/src/commands/build.dart @@ -25,7 +25,7 @@ class BuildCommand extends FlutterCommand { addSubcommand(BuildAarCommand()); addSubcommand(BuildApkCommand(verboseHelp: verboseHelp)); addSubcommand(BuildAppBundleCommand(verboseHelp: verboseHelp)); - addSubcommand(BuildAotCommand(verboseHelp: verboseHelp)); + addSubcommand(BuildAotCommand()); addSubcommand(BuildIOSCommand()); addSubcommand(BuildIOSFrameworkCommand( aotBuilder: AotBuilder(), diff --git a/packages/flutter_tools/lib/src/commands/build_aot.dart b/packages/flutter_tools/lib/src/commands/build_aot.dart index d0baa7b76c1..fb5694255d2 100644 --- a/packages/flutter_tools/lib/src/commands/build_aot.dart +++ b/packages/flutter_tools/lib/src/commands/build_aot.dart @@ -14,7 +14,7 @@ import 'build.dart'; /// Builds AOT snapshots into platform specific library containers. class BuildAotCommand extends BuildSubCommand with TargetPlatformBasedDevelopmentArtifacts { - BuildAotCommand({bool verboseHelp = false, this.aotBuilder}) { + BuildAotCommand({this.aotBuilder}) { addTreeShakeIconsFlag(); usesTargetOption(); addBuildModeFlags(); @@ -51,10 +51,6 @@ class BuildAotCommand extends BuildSubCommand with TargetPlatformBasedDevelopmen help: 'Build the AOT bundle with bitcode. Requires a compatible bitcode engine.', hide: true, ); - // --track-widget-creation is exposed as a flag here to deal with build - // invalidation issues, but it is ignored -- there are no plans to support - // it for AOT mode. - usesTrackWidgetCreation(hasEffect: false, verboseHelp: verboseHelp); } AotBuilder aotBuilder;