From bc11c2a8c4a3f9d9e6d6f81a0bc69b0844e17bd6 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Thu, 17 Sep 2020 15:24:52 -0700 Subject: [PATCH] [flutter_tools] update windows config feature (#65867) --- packages/flutter_tools/lib/src/features.dart | 4 ++++ .../flutter_tools/test/general.shard/features_test.dart | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/flutter_tools/lib/src/features.dart b/packages/flutter_tools/lib/src/features.dart index 05d814c758a..2fadc7f45b2 100644 --- a/packages/flutter_tools/lib/src/features.dart +++ b/packages/flutter_tools/lib/src/features.dart @@ -173,6 +173,10 @@ const Feature flutterWindowsDesktopFeature = Feature( available: true, enabledByDefault: false, ), + dev: FeatureChannelSetting( + available: true, + enabledByDefault: false, + ), ); /// The [Feature] for Android devices. diff --git a/packages/flutter_tools/test/general.shard/features_test.dart b/packages/flutter_tools/test/general.shard/features_test.dart index 4d3b7353b23..dd5c586f65f 100644 --- a/packages/flutter_tools/test/general.shard/features_test.dart +++ b/packages/flutter_tools/test/general.shard/features_test.dart @@ -98,7 +98,7 @@ void main() { test('flutter Windows desktop help string', () { expect(flutterWindowsDesktopFeature.generateHelpMessage(), 'Enable or disable Flutter for desktop on Windows. ' - 'This setting will take effect on the master channel.'); + 'This setting will take effect on the master and dev channels.'); }); test('help string on multiple channels', () { @@ -387,18 +387,18 @@ void main() { expect(featureFlags.isWindowsEnabled, false); })); - test('flutter windows desktop not enabled with config on dev', () => testbed.run(() { + test('flutter windows desktop enabled with config on dev', () => testbed.run(() { when(mockFlutterVerion.channel).thenReturn('dev'); when(mockFlutterConfig.getValue('enable-windows-desktop') as bool).thenReturn(true); - expect(featureFlags.isWindowsEnabled, false); + expect(featureFlags.isWindowsEnabled, true); })); test('flutter windows desktop not enabled with environment variable on dev', () => testbed.run(() { when(mockFlutterVerion.channel).thenReturn('dev'); when(mockPlatform.environment).thenReturn({'FLUTTER_WINDOWS': 'true'}); - expect(featureFlags.isWindowsEnabled, false); + expect(featureFlags.isWindowsEnabled, true); })); test('flutter windows desktop off by default on beta', () => testbed.run(() {