development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-08-25 02:46:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] skip selectable text goldens for instability. (#143627)

Browse source 
Similar to other issues, appears that text goldens are really unstable with Impeller.

Part of https://github.com/flutter/flutter/issues/143616
This commit is contained in:
Jonah Williams 2024-02-16 20:21:17 -08:00 committed by GitHub
parent 789acb324d
commit ae1488cfe8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/flutter/test/widgets/selectable_text_test.dart
View file

@ -19,6 +19,7 @@ import 'package:flutter/rendering.dart';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
import '../impeller_test_helpers.dart';
import '../widgets/clipboard_utils.dart';
import '../widgets/editable_text_utils.dart' show textOffsetToPosition;
import '../widgets/semantics_tester.dart';
@ -5370,7 +5371,7 @@ void main() {
find.byType(MaterialApp),
matchesGoldenFile('selectable_text_golden.TextSelectionStyle.1.png'),
);
});
}, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
testWidgets('text selection style 2', (WidgetTester tester) async {
await tester.pumpWidget(
@ -5422,7 +5423,7 @@ void main() {
find.byType(MaterialApp),
matchesGoldenFile('selectable_text_golden.TextSelectionStyle.2.png'),
);
});
}, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
testWidgets('keeps alive when has focus', (WidgetTester tester) async {
await tester.pumpWidget(