development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-09-17 23:31:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Pin url_launcher to federated version in plugin_lint_mac (#98171)

Browse source
This commit is contained in:
Jenn Magder 2022-02-10 18:53:01 -08:00 committed by GitHub
parent 33a16f44aa
commit ac708f1cb8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
dev/devicelab/bin/tasks/plugin_lint_mac.dart
View file

@ -239,7 +239,7 @@ Future<void> main() async {
// Add the new plugins we just made.
pubspecContent = pubspecContent.replaceFirst(
'\ndependencies:\n',
'\ndependencies:\n $objcPluginName:\n path: $objcPluginPath\n $swiftPluginName:\n path: $swiftPluginPath\n url_launcher:\n url_launcher_macos:\n',
'\ndependencies:\n $objcPluginName:\n path: $objcPluginPath\n $swiftPluginName:\n path: $swiftPluginPath\n url_launcher: 6.0.16\n url_launcher_macos:\n',
);
objcPubspec.writeAsStringSync(pubspecContent, flush: true);
@ -399,7 +399,7 @@ Future<void> main() async {
final File podfileLockFile = File(path.join(swiftAppPath, 'ios', 'Podfile.lock'));
final String podfileLockOutput = podfileLockFile.readAsStringSync();
if (!podfileLockOutput.contains(':path: ".symlinks/plugins/url_launcher/ios"')
if (!podfileLockOutput.contains(':path: ".symlinks/plugins/url_launcher_ios/ios"')
|| !podfileLockOutput.contains(':path: Flutter')
// test_plugin_objc no longer supports iOS, shouldn't be present.
|| podfileLockOutput.contains(':path: ".symlinks/plugins/test_plugin_objc/ios"')
@ -417,7 +417,7 @@ Future<void> main() async {
checkDirectoryExists(path.join(
pluginSymlinks,
'url_launcher',
'url_launcher_ios',
'ios',
));
@ -447,7 +447,7 @@ void _validateIosPodfile(String appPath) {
final File podfileLockFile = File(path.join(appPath, 'ios', 'Podfile.lock'));
final String podfileLockOutput = podfileLockFile.readAsStringSync();
if (!podfileLockOutput.contains(':path: ".symlinks/plugins/url_launcher/ios"')
if (!podfileLockOutput.contains(':path: ".symlinks/plugins/url_launcher_ios/ios"')
|| !podfileLockOutput.contains(':path: Flutter')
|| !podfileLockOutput.contains(':path: ".symlinks/plugins/test_plugin_objc/ios"')
|| !podfileLockOutput.contains(':path: ".symlinks/plugins/test_plugin_swift/ios"')
@ -479,7 +479,7 @@ void _validateIosPodfile(String appPath) {
checkDirectoryExists(path.join(
pluginSymlinks,
'url_launcher',
'url_launcher_ios',
'ios',
));
@ -516,7 +516,7 @@ void _validateMacOSPodfile(String appPath) {
if (!podfileLockOutput.contains(':path: Flutter/ephemeral\n')
|| !podfileLockOutput.contains(':path: Flutter/ephemeral/.symlinks/plugins/url_launcher_macos/macos')
|| !podfileLockOutput.contains(':path: Flutter/ephemeral/.symlinks/plugins/test_plugin_swift/macos')
|| podfileLockOutput.contains('url_launcher/')) {
|| podfileLockOutput.contains('url_launcher_ios/')) {
print(podfileLockOutput);
throw TaskResult.failure('macOS Podfile.lock does not contain expected pods');
}
@ -546,7 +546,7 @@ void _validateMacOSPodfile(String appPath) {
checkDirectoryNotExists(path.join(
pluginSymlinks,
'url_launcher',
'url_launcher_ios',
));
checkDirectoryExists(path.join(