development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 03:32:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Modified platform specific golden file test.

Browse source
This commit is contained in:
Kate Lovett 2019-04-25 15:50:53 -07:00
parent 04ad0ffa1e
commit abb555fe94
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/flutter/test/widgets/widget_inspector_test.dart
View file

@ -1999,9 +1999,10 @@ class TestWidgetInspectorService extends Object with WidgetInspectorService {
); );
// Add a margin so that the clip icon shows up in the screenshot. // Add a margin so that the clip icon shows up in the screenshot.
// This golden image is platform dependent due to the clip icon. // This golden image is platform dependent due to the clip icon.
final String platform = Platform.operatingSystem;
await expectLater( await expectLater(
clipRectScreenshot, clipRectScreenshot,
matchesSkiaGoldFile('inspector.clipRect_debugPaint_margin.png'), matchesSkiaGoldFile('inspector.clipRect_debugPaint_margin.$platform.png'),
); );
// Verify we get the same image if we go through the service extension // Verify we get the same image if we go through the service extension

2
packages/flutter_goldens_client/lib/client.dart
View file

@ -189,7 +189,7 @@ class SkiaGoldClient {
Future<String> _getCommitHash() async { Future<String> _getCommitHash() async {
// TODO(katelovett): Remove after pre-commit tests can be ingested by Skia Gold // TODO(katelovett): Remove after pre-commit tests can be ingested by Skia Gold
return 'd4e4726ac262b9f78b002b696f915f552fed3fc8'; return 'e51947241b37790a9e4e33bfdef59aaa9b930851';
// if (!flutterRoot.existsSync()) { // if (!flutterRoot.existsSync()) {
// return null; // return null;
// } else { // } else {