development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-09-21 17:22:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Post submit review changes for chip (#15835)

Browse source
This commit is contained in:
Greg Spencer 2018-03-24 17:55:40 -07:00 committed by GitHub
parent e91683942c
commit a6d8ca2980
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
packages/flutter/lib/src/material/chip.dart
View file

@ -53,7 +53,7 @@ const double _kEdgePadding = 4.0;
/// * [CircleAvatar], which shows images or initials of people.
/// * <https://material.google.com/components/chips.html>
class Chip extends StatelessWidget {
/// Creates a material design chip
/// Creates a material design chip.
///
/// The [label] and [border] arguments may not be null.
const Chip({
@ -714,6 +714,14 @@ class _RenderChip extends RenderBox {
}
}
doPaint(container);
doPaint(avatar);
doPaint(deleteIcon);
doPaint(label);
}
@override
void debugPaint(PaintingContext context, Offset offset) {
assert(!_debugShowTapTargetOutlines ||
() {
// Draws a rect around the tap targets to help with visualizing where
@ -731,11 +739,6 @@ class _RenderChip extends RenderBox {
);
return true;
}());
doPaint(container);
doPaint(avatar);
doPaint(deleteIcon);
doPaint(label);
}
@override

2
packages/flutter/lib/src/material/tooltip.dart
View file

@ -170,9 +170,9 @@ class _TooltipState extends State<Tooltip> with SingleTickerProviderStateMixin {
@override
void deactivate() {
super.deactivate();
if (_entry != null)
_controller.reverse();
super.deactivate();
}
@override