development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 03:32:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Turn on win_build_tests_2_3 shard, skip 'build windows' tests (#82386)

Browse source
This commit is contained in:
Jenn Magder 2021-05-12 17:16:13 -07:00 committed by GitHub
parent fe43a8c64a
commit a66e5a7fa0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
dev/bots/test.dart
View file

@ -442,8 +442,7 @@ Future<void> _runExampleProjectBuildTests(FileSystemEntity exampleDirectory) asy
} }
if (Platform.isWindows) { if (Platform.isWindows) {
if (Directory(path.join(examplePath, 'windows')).existsSync()) { if (Directory(path.join(examplePath, 'windows')).existsSync()) {
await _flutterBuildWin32(examplePath, release: false, additionalArgs: additionalArgs, verifyCaching: verifyCaching); // TODO(jmagman): Re-add Windows build tests when Visual Studio is available https://github.com/flutter/flutter/issues/81956.
await _flutterBuildWin32(examplePath, release: true, additionalArgs: additionalArgs, verifyCaching: verifyCaching);
} else { } else {
print('Example project ${path.basename(examplePath)} has no windows directory, skipping Win32'); print('Example project ${path.basename(examplePath)} has no windows directory, skipping Win32');
} }
@ -507,21 +506,6 @@ Future<void> _flutterBuildMacOS(String relativePathToApplication, {
); );
} }
Future<void> _flutterBuildWin32(String relativePathToApplication, {
@required bool release,
bool verifyCaching = false,
List<String> additionalArgs = const <String>[],
}) async {
assert(Platform.isWindows);
await runCommand(flutter, <String>['config', '--enable-windows-desktop']);
print('${green}Testing Windows build$reset for $cyan$relativePathToApplication$reset...');
await _flutterBuild(relativePathToApplication, 'Windows', 'windows',
release: release,
verifyCaching: verifyCaching,
additionalArgs: additionalArgs
);
}
Future<void> _flutterBuild( Future<void> _flutterBuild(
String relativePathToApplication, String relativePathToApplication,
String platformLabel, String platformLabel,

2
dev/try_builders.json
View file

@ -579,7 +579,7 @@
"name": "Windows build_tests_2_3", "name": "Windows build_tests_2_3",
"repo": "flutter", "repo": "flutter",
"task_name": "win_build_tests_2_3", "task_name": "win_build_tests_2_3",
"enabled": false "enabled": true
}, },
{ {
"name": "Windows build_tests_3_3", "name": "Windows build_tests_3_3",