development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 03:32:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Ink decoration image does not render (#121521)

Browse source
This commit is contained in:
Bruno Leroux 2023-02-27 17:51:21 +01:00 committed by GitHub
parent d193f050b5
commit a297cb368b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/flutter/lib/src/material/ink_decoration.dart
View file

@ -288,7 +288,7 @@ class _InkState extends State<Ink> {
_ink!.decoration = widget.decoration;
_ink!.configuration = createLocalImageConfiguration(context);
}
return widget.child ?? const SizedBox();
return widget.child ?? ConstrainedBox(constraints: const BoxConstraints.expand());
}
@override

36
packages/flutter/test/material/ink_paint_test.dart
View file

@ -9,20 +9,17 @@ import 'package:flutter_test/flutter_test.dart';
import '../rendering/mock_canvas.dart';
void main() {
testWidgets('The Ink widget renders a SizedBox by default', (WidgetTester tester) async {
testWidgets('The Ink widget expands when no dimensions are set', (WidgetTester tester) async {
await tester.pumpWidget(
Material(
child: Ink(),
),
);
Finder sizedBox = find.descendant(
of: find.byType(Ink),
matching: find.byType(SizedBox),
);
expect(sizedBox, findsOneWidget);
expect(tester.getSize(sizedBox).height, 600.0);
expect(tester.getSize(sizedBox).width, 800.0);
expect(find.byType(Ink), findsOneWidget);
expect(tester.getSize(find.byType(Ink)), const Size(800.0, 600.0));
});
testWidgets('The Ink widget fits the specified size', (WidgetTester tester) async {
const double height = 150.0;
const double width = 200.0;
await tester.pumpWidget(
@ -36,13 +33,24 @@ void main() {
),
);
await tester.pumpAndSettle();
sizedBox = find.descendant(
of: find.byType(Ink),
matching: find.byType(SizedBox),
expect(find.byType(Ink), findsOneWidget);
expect(tester.getSize(find.byType(Ink)), const Size(width, height));
});
testWidgets('The Ink widget expands on a unspecified dimension', (WidgetTester tester) async {
const double height = 150.0;
await tester.pumpWidget(
Material(
child: Center( // used to constrain to child's size
child: Ink(
height: height,
),
),
),
);
expect(sizedBox, findsNWidgets(2));
expect(tester.getSize(sizedBox.at(0)).height, height);
expect(tester.getSize(sizedBox.at(0)).width, width);
await tester.pumpAndSettle();
expect(find.byType(Ink), findsOneWidget);
expect(tester.getSize(find.byType(Ink)), const Size(800, height));
});
testWidgets('The InkWell widget renders an ink splash', (WidgetTester tester) async {