mirror of
https://github.com/flutter/flutter
synced 2024-10-13 03:32:55 +00:00
Updated some skip test comments that were missed in the audit. (#88893)
This commit is contained in:
parent
884dfc260d
commit
a1cd3f45e0
|
@ -180,7 +180,10 @@ void main([List<String> args = const <String>[]]) {
|
||||||
// Assert that we can use semantics related finders in profile mode.
|
// Assert that we can use semantics related finders in profile mode.
|
||||||
final int id = await driver.getSemanticsId(find.bySemanticsLabel('Material'));
|
final int id = await driver.getSemanticsId(find.bySemanticsLabel('Material'));
|
||||||
expect(id, greaterThan(-1));
|
expect(id, greaterThan(-1));
|
||||||
}, skip: !withSemantics, timeout: Timeout.none);
|
},
|
||||||
|
skip: !withSemantics, // [intended] test only makes sense when semantics are turned on.
|
||||||
|
timeout: Timeout.none,
|
||||||
|
);
|
||||||
|
|
||||||
test('all demos', () async {
|
test('all demos', () async {
|
||||||
// Collect timeline data for just a limited set of demos to avoid OOMs.
|
// Collect timeline data for just a limited set of demos to avoid OOMs.
|
||||||
|
|
|
@ -32,7 +32,7 @@ void main() {
|
||||||
|
|
||||||
expect(await compute(test1Async, 0), 1);
|
expect(await compute(test1Async, 0), 1);
|
||||||
expect(compute(test2Async, 0), throwsException);
|
expect(compute(test2Async, 0), throwsException);
|
||||||
}, skip: kIsWeb);
|
}, skip: kIsWeb); // [intended] isn't supported on the web.
|
||||||
|
|
||||||
test('compute closes all ports', () async {
|
test('compute closes all ports', () async {
|
||||||
// Run a Dart script that calls compute().
|
// Run a Dart script that calls compute().
|
||||||
|
|
|
@ -5203,7 +5203,10 @@ void main() {
|
||||||
|
|
||||||
const String expected = ' housa bige jumped over a mouse';
|
const String expected = ' housa bige jumped over a mouse';
|
||||||
expect(find.text(expected), findsOneWidget);
|
expect(find.text(expected), findsOneWidget);
|
||||||
}, skip: areKeyEventsHandledByPlatform, variant: KeySimulatorTransitModeVariant.all());
|
},
|
||||||
|
skip: areKeyEventsHandledByPlatform, // [intended] only applies to platforms where we handle key events.
|
||||||
|
variant: KeySimulatorTransitModeVariant.all()
|
||||||
|
);
|
||||||
|
|
||||||
testWidgets('Select all test', (WidgetTester tester) async {
|
testWidgets('Select all test', (WidgetTester tester) async {
|
||||||
final FocusNode focusNode = FocusNode();
|
final FocusNode focusNode = FocusNode();
|
||||||
|
|
|
@ -367,8 +367,7 @@ void main() {
|
||||||
|
|
||||||
// TODO(yjbanov): ahem.ttf doesn't have Chinese glyphs, making this test
|
// TODO(yjbanov): ahem.ttf doesn't have Chinese glyphs, making this test
|
||||||
// sensitive to browser/OS when running in web mode:
|
// sensitive to browser/OS when running in web mode:
|
||||||
// https://github.com/flutter/flutter/issues/83129
|
}, skip: kIsWeb); // https://github.com/flutter/flutter/issues/83129
|
||||||
}, skip: kIsWeb);
|
|
||||||
|
|
||||||
test('text is painted above selection', () {
|
test('text is painted above selection', () {
|
||||||
final TextSelectionDelegate delegate = FakeEditableTextState();
|
final TextSelectionDelegate delegate = FakeEditableTextState();
|
||||||
|
|
|
@ -5261,7 +5261,7 @@ void main() {
|
||||||
);
|
);
|
||||||
expect(controller.text, equals(testText), reason: 'on $platform');
|
expect(controller.text, equals(testText), reason: 'on $platform');
|
||||||
},
|
},
|
||||||
skip: kIsWeb,
|
skip: kIsWeb, // [intended] on web these keys are handled by the browser.
|
||||||
variant: TargetPlatformVariant.all(),
|
variant: TargetPlatformVariant.all(),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
@ -5404,7 +5404,7 @@ void main() {
|
||||||
);
|
);
|
||||||
expect(controller.text, equals(testText), reason: 'on $platform');
|
expect(controller.text, equals(testText), reason: 'on $platform');
|
||||||
},
|
},
|
||||||
skip: kIsWeb,
|
skip: kIsWeb, // [intended] on web these keys are handled by the browser.
|
||||||
variant: TargetPlatformVariant.all(),
|
variant: TargetPlatformVariant.all(),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue