mirror of
https://github.com/flutter/flutter
synced 2024-10-13 19:52:53 +00:00
Bump recommended CocoaPods version to 1.8 (#52071)
This commit is contained in:
parent
f6a55125d2
commit
a14ac4e3c8
|
@ -69,7 +69,7 @@ class CocoaPods {
|
||||||
Future<String> _versionText;
|
Future<String> _versionText;
|
||||||
|
|
||||||
String get cocoaPodsMinimumVersion => '1.6.0';
|
String get cocoaPodsMinimumVersion => '1.6.0';
|
||||||
String get cocoaPodsRecommendedVersion => '1.6.0';
|
String get cocoaPodsRecommendedVersion => '1.8.0';
|
||||||
|
|
||||||
Future<bool> get isInstalled =>
|
Future<bool> get isInstalled =>
|
||||||
processUtils.exitsHappy(<String>['which', 'pod']);
|
processUtils.exitsHappy(<String>['which', 'pod']);
|
||||||
|
|
|
@ -68,7 +68,7 @@ void main() {
|
||||||
projectUnderTest = FlutterProject.fromDirectory(fs.directory('project'));
|
projectUnderTest = FlutterProject.fromDirectory(fs.directory('project'));
|
||||||
projectUnderTest.ios.xcodeProject.createSync(recursive: true);
|
projectUnderTest.ios.xcodeProject.createSync(recursive: true);
|
||||||
cocoaPodsUnderTest = CocoaPods();
|
cocoaPodsUnderTest = CocoaPods();
|
||||||
pretendPodVersionIs('1.6.0');
|
pretendPodVersionIs('1.8.0');
|
||||||
fs.file(fs.path.join(
|
fs.file(fs.path.join(
|
||||||
Cache.flutterRoot, 'packages', 'flutter_tools', 'templates', 'cocoapods', 'Podfile-ios-objc',
|
Cache.flutterRoot, 'packages', 'flutter_tools', 'templates', 'cocoapods', 'Podfile-ios-objc',
|
||||||
))
|
))
|
||||||
|
@ -173,9 +173,17 @@ void main() {
|
||||||
ProcessManager: () => mockProcessManager,
|
ProcessManager: () => mockProcessManager,
|
||||||
});
|
});
|
||||||
|
|
||||||
testUsingContext('detects at recommended version', () async {
|
testUsingContext('detects below recommended version', () async {
|
||||||
pretendPodIsInstalled();
|
pretendPodIsInstalled();
|
||||||
pretendPodVersionIs('1.6.0');
|
pretendPodVersionIs('1.6.0');
|
||||||
|
expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.belowRecommendedVersion);
|
||||||
|
}, overrides: <Type, Generator>{
|
||||||
|
ProcessManager: () => mockProcessManager,
|
||||||
|
});
|
||||||
|
|
||||||
|
testUsingContext('detects at recommended version', () async {
|
||||||
|
pretendPodIsInstalled();
|
||||||
|
pretendPodVersionIs('1.8.0');
|
||||||
expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.recommended);
|
expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.recommended);
|
||||||
}, overrides: <Type, Generator>{
|
}, overrides: <Type, Generator>{
|
||||||
ProcessManager: () => mockProcessManager,
|
ProcessManager: () => mockProcessManager,
|
||||||
|
@ -183,7 +191,7 @@ void main() {
|
||||||
|
|
||||||
testUsingContext('detects above recommended version', () async {
|
testUsingContext('detects above recommended version', () async {
|
||||||
pretendPodIsInstalled();
|
pretendPodIsInstalled();
|
||||||
pretendPodVersionIs('1.6.1');
|
pretendPodVersionIs('1.8.1');
|
||||||
expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.recommended);
|
expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.recommended);
|
||||||
}, overrides: <Type, Generator>{
|
}, overrides: <Type, Generator>{
|
||||||
ProcessManager: () => mockProcessManager,
|
ProcessManager: () => mockProcessManager,
|
||||||
|
|
Loading…
Reference in a new issue