From 9f5fd75e54fccbfd7ea0f66b12592a537621ae00 Mon Sep 17 00:00:00 2001 From: LouiseHsu Date: Thu, 14 Mar 2024 10:14:20 -0700 Subject: [PATCH] [framework] fix incorrect chinese localizations for Search Web and Share in selection controls (#144857) Fixes https://github.com/flutter/flutter/issues/144825 Corresponding translation suggestions: https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-TW (I accidentally pressed submit 3 times :( ) https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-HK https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-CN https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=8883913494819754382&language=zh-CN ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. --- .../lib/src/l10n/cupertino_zh.arb | 4 ++-- .../lib/src/l10n/cupertino_zh_HK.arb | 2 +- .../lib/src/l10n/cupertino_zh_TW.arb | 2 +- .../src/l10n/generated_cupertino_localizations.dart | 12 ++++++------ .../src/l10n/generated_material_localizations.dart | 12 ++++++------ .../lib/src/l10n/material_zh.arb | 4 ++-- .../lib/src/l10n/material_zh_HK.arb | 2 +- .../lib/src/l10n/material_zh_TW.arb | 2 +- 8 files changed, 20 insertions(+), 20 deletions(-) diff --git a/packages/flutter_localizations/lib/src/l10n/cupertino_zh.arb b/packages/flutter_localizations/lib/src/l10n/cupertino_zh.arb index b0f76097d64..491afd25596 100644 --- a/packages/flutter_localizations/lib/src/l10n/cupertino_zh.arb +++ b/packages/flutter_localizations/lib/src/l10n/cupertino_zh.arb @@ -25,7 +25,7 @@ "noSpellCheckReplacementsLabel": "找不到替换文字", "menuDismissLabel": "关闭菜单", "lookUpButtonLabel": "查询", - "searchWebButtonLabel": "在网络上搜索", - "shareButtonLabel": "分享…", + "searchWebButtonLabel": "搜索", + "shareButtonLabel": "共享…", "clearButtonLabel": "Clear" } diff --git a/packages/flutter_localizations/lib/src/l10n/cupertino_zh_HK.arb b/packages/flutter_localizations/lib/src/l10n/cupertino_zh_HK.arb index d5807200576..7a07502ad95 100644 --- a/packages/flutter_localizations/lib/src/l10n/cupertino_zh_HK.arb +++ b/packages/flutter_localizations/lib/src/l10n/cupertino_zh_HK.arb @@ -1,5 +1,5 @@ { - "searchWebButtonLabel": "搜尋網頁", + "searchWebButtonLabel": "搜尋", "shareButtonLabel": "分享…", "lookUpButtonLabel": "查詢", "noSpellCheckReplacementsLabel": "找不到替換字詞", diff --git a/packages/flutter_localizations/lib/src/l10n/cupertino_zh_TW.arb b/packages/flutter_localizations/lib/src/l10n/cupertino_zh_TW.arb index 3b5532c9df2..062d244e832 100644 --- a/packages/flutter_localizations/lib/src/l10n/cupertino_zh_TW.arb +++ b/packages/flutter_localizations/lib/src/l10n/cupertino_zh_TW.arb @@ -1,6 +1,6 @@ { "lookUpButtonLabel": "查詢", - "searchWebButtonLabel": "在網路上搜尋", + "searchWebButtonLabel": "搜尋", "shareButtonLabel": "分享…", "noSpellCheckReplacementsLabel": "找不到替代文字", "menuDismissLabel": "關閉選單", diff --git a/packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart b/packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart index 90aa1b73a8b..1d63547f300 100644 --- a/packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart +++ b/packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart @@ -14036,13 +14036,13 @@ class CupertinoLocalizationZh extends GlobalCupertinoLocalizations { String get searchTextFieldPlaceholderLabel => '搜索'; @override - String get searchWebButtonLabel => '在网络上搜索'; + String get searchWebButtonLabel => '搜索'; @override String get selectAllButtonLabel => '全选'; @override - String get shareButtonLabel => '分享…'; + String get shareButtonLabel => '共享…'; @override String get tabSemanticsLabelRaw => r'第 $tabIndex 个标签，共 $tabCount 个'; @@ -14183,11 +14183,14 @@ class CupertinoLocalizationZhHant extends CupertinoLocalizationZh { String get searchTextFieldPlaceholderLabel => '搜尋'; @override - String get searchWebButtonLabel => '搜尋網頁'; + String get searchWebButtonLabel => '搜尋'; @override String get selectAllButtonLabel => '全選'; + @override + String get shareButtonLabel => '分享…'; + @override String get tabSemanticsLabelRaw => r'$tabCount 個分頁中嘅第 $tabIndex 個'; @@ -14239,9 +14242,6 @@ class CupertinoLocalizationZhHantTw extends CupertinoLocalizationZhHant { required super.decimalFormat, }); - @override - String get searchWebButtonLabel => '在網路上搜尋'; - @override String get noSpellCheckReplacementsLabel => '找不到替代文字'; diff --git a/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart b/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart index 85a30da10da..d8e9d3db994 100644 --- a/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart +++ b/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart @@ -44063,7 +44063,7 @@ class MaterialLocalizationZh extends GlobalMaterialLocalizations { String get searchFieldLabel => '搜索'; @override - String get searchWebButtonLabel => '在网络上搜索'; + String get searchWebButtonLabel => '搜索'; @override String get selectAllButtonLabel => '全选'; @@ -44093,7 +44093,7 @@ class MaterialLocalizationZh extends GlobalMaterialLocalizations { String? get selectedRowCountTitleZero => null; @override - String get shareButtonLabel => '分享…'; + String get shareButtonLabel => '共享…'; @override String get showAccountsLabel => '显示账号'; @@ -44476,7 +44476,7 @@ class MaterialLocalizationZhHant extends MaterialLocalizationZh { String get searchFieldLabel => '搜尋'; @override - String get searchWebButtonLabel => '搜尋網頁'; + String get searchWebButtonLabel => '搜尋'; @override String get selectAllButtonLabel => '全部選取'; @@ -44490,6 +44490,9 @@ class MaterialLocalizationZhHant extends MaterialLocalizationZh { @override String get selectedRowCountTitleOther => r'已選取 $selectedRowCount 個項目'; + @override + String get shareButtonLabel => '分享…'; + @override String get showAccountsLabel => '顯示帳戶'; @@ -44564,9 +44567,6 @@ class MaterialLocalizationZhHantTw extends MaterialLocalizationZhHant { required super.twoDigitZeroPaddedFormat, }); - @override - String get searchWebButtonLabel => '在網路上搜尋'; - @override String get scanTextButtonLabel => '掃描文字'; diff --git a/packages/flutter_localizations/lib/src/l10n/material_zh.arb b/packages/flutter_localizations/lib/src/l10n/material_zh.arb index f5ab037f546..d702702d348 100644 --- a/packages/flutter_localizations/lib/src/l10n/material_zh.arb +++ b/packages/flutter_localizations/lib/src/l10n/material_zh.arb @@ -143,8 +143,8 @@ "collapsedHint": "已展开", "menuDismissLabel": "关闭菜单", "lookUpButtonLabel": "查询", - "searchWebButtonLabel": "在网络上搜索", - "shareButtonLabel": "分享…", + "searchWebButtonLabel": "搜索", + "shareButtonLabel": "共享…", "clearButtonTooltip": "Clear text", "selectedDateLabel": "Selected" } diff --git a/packages/flutter_localizations/lib/src/l10n/material_zh_HK.arb b/packages/flutter_localizations/lib/src/l10n/material_zh_HK.arb index bb731fa6766..a8d62dd50bf 100644 --- a/packages/flutter_localizations/lib/src/l10n/material_zh_HK.arb +++ b/packages/flutter_localizations/lib/src/l10n/material_zh_HK.arb @@ -1,5 +1,5 @@ { - "searchWebButtonLabel": "搜尋網頁", + "searchWebButtonLabel": "搜尋", "shareButtonLabel": "分享…", "scanTextButtonLabel": "掃瞄文字", "lookUpButtonLabel": "查詢", diff --git a/packages/flutter_localizations/lib/src/l10n/material_zh_TW.arb b/packages/flutter_localizations/lib/src/l10n/material_zh_TW.arb index b25886bf429..4722dbce5fc 100644 --- a/packages/flutter_localizations/lib/src/l10n/material_zh_TW.arb +++ b/packages/flutter_localizations/lib/src/l10n/material_zh_TW.arb @@ -1,6 +1,6 @@ { "lookUpButtonLabel": "查詢", - "searchWebButtonLabel": "在網路上搜尋", + "searchWebButtonLabel": "搜尋", "shareButtonLabel": "分享…", "scanTextButtonLabel": "掃描文字", "menuDismissLabel": "關閉選單",