development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-06 00:09:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix a CupertinoDatePicker bug (#112697)

Browse source
This commit is contained in:
xubaolin 2022-10-08 02:35:15 +08:00 committed by GitHub
parent 529184bcca
commit 9bd6ff33ef
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 45 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/flutter/lib/src/rendering/list_wheel_viewport.dart
View file

@ -681,10 +681,14 @@ class RenderListWheelViewport
/// by [childManager].
@override
void performLayout() {
// Apply the dimensions first in case it changes the scroll offset which
// determines what should be shown.
offset.applyViewportDimension(_viewportExtent);
offset.applyContentDimensions(_minEstimatedScrollExtent, _maxEstimatedScrollExtent);
// Apply the content dimensions first if it has exact dimensions in case it
// changes the scroll offset which determines what should be shown. Such as
// if the child count decrease, we should correct the pixels first, otherwise,
// it may be shown blank null children.
if (childManager.childCount != null) {
offset.applyContentDimensions(_minEstimatedScrollExtent, _maxEstimatedScrollExtent);
}
// The height, in pixel, that children will be visible and might be laid out
// and painted.

38
packages/flutter/test/widgets/list_wheel_scroll_view_test.dart
View file

@ -288,6 +288,44 @@ void main() {
});
group('layout', () {
testWidgets('Flings with high velocity should not break the children lower and upper limits', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/112526
final FixedExtentScrollController controller = FixedExtentScrollController();
Widget buildFrame() {
return Directionality(
textDirection: TextDirection.ltr,
child: ListWheelScrollView.useDelegate(
physics: const FixedExtentScrollPhysics(),
controller: controller,
itemExtent: 400.0,
onSelectedItemChanged: (_) { },
childDelegate: ListWheelChildBuilderDelegate(
builder: (BuildContext context, int index) {
if (index < 0 || index > 5) {
return null;
}
return SizedBox(
width: 400.0,
height: 400.0,
child: Text(index.toString()),
);
},
),
),
);
}
await tester.pumpWidget(buildFrame());
expect(tester.renderObject(find.text('0')).attached, true);
expect(tester.renderObject(find.text('1')).attached, true);
expect(find.text('2'), findsNothing);
expect(controller.selectedItem, 0);
// Flings with high velocity and stop at the child boundary.
await tester.fling(find.byType(ListWheelScrollView), const Offset(0.0, 40000.0), 8000.0);
expect(controller.selectedItem, 0);
}, variant: TargetPlatformVariant(TargetPlatform.values.toSet()));
// Regression test for https://github.com/flutter/flutter/issues/90953
testWidgets('ListWheelScrollView childDelegate update test 2', (WidgetTester tester) async {
final FixedExtentScrollController controller = FixedExtentScrollController( initialItem: 2 );