development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 03:32:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Consolidate ascii spinner stop in devtools activation (#75679)

Browse source
This commit is contained in:
Jenn Magder 2021-02-09 16:06:35 -08:00 committed by GitHub
parent b854116333
commit 8f3a6245f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/flutter_tools/lib/src/devtools_launcher.dart
View file

@ -153,18 +153,17 @@ class DevtoolsServerLauncher extends DevtoolsLauncher {
'devtools' 'devtools'
]); ]);
if (_devToolsActivateProcess.exitCode != 0) { if (_devToolsActivateProcess.exitCode != 0) {
status.cancel();
_logger.printError('Error running `pub global activate ' _logger.printError('Error running `pub global activate '
'devtools`:\n${_devToolsActivateProcess.stderr}'); 'devtools`:\n${_devToolsActivateProcess.stderr}');
return false; return false;
} }
status.stop();
_persistentToolState.lastDevToolsActivationTime = DateTime.now(); _persistentToolState.lastDevToolsActivationTime = DateTime.now();
return true; return true;
} on Exception catch (e, _) { } on Exception catch (e, _) {
status.stop();
_logger.printError('Error running `pub global activate devtools`: $e'); _logger.printError('Error running `pub global activate devtools`: $e');
return false; return false;
} finally {
status.stop();
} }
} }