development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 19:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Roll engine after dart roll (#12473)" (#12477)

Browse source 
This reverts commit e706169814.

This causes preview-dart-2 test failures.
This commit is contained in:
Alexander Aprelev 2017-10-10 07:27:39 -07:00 committed by GitHub
parent e706169814
commit 7f5b973cb1
5 changed files with 8 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bin/internal/engine.version
View file

@ -1 +1 @@
74e58f66d492a28a2c47ac5402d0b8b8a740cf62
459f722b86415da01386fe41f37bafa842f11ae8

5
packages/flutter/lib/src/cupertino/route.dart
View file

@ -88,9 +88,8 @@ class CupertinoPageRoute<T> extends PageRoute<T> {
assert(settings != null),
assert(maintainState != null),
assert(fullscreenDialog != null),
super(settings: settings, fullscreenDialog: fullscreenDialog) {
assert(opaque); // PageRoute makes it return true.
}
assert(opaque), // PageRoute makes it return true.
super(settings: settings, fullscreenDialog: fullscreenDialog);
/// Builds the primary contents of the route.
final WidgetBuilder builder;

2
packages/flutter/lib/src/foundation/assertions.dart
View file

@ -329,7 +329,7 @@ class FlutterError extends AssertionError {
'_FakeAsync',
'_FrameCallbackEntry',
];
final RegExp stackParser = new RegExp(r'^#[0-9]+ +([^.]+).* \(([^/]*)/.+:[0-9]+(?::[0-9]+)?\)$');
final RegExp stackParser = new RegExp(r'^#[0-9]+ +([^.]+).* \(([^/]*)/[^:]+:[0-9]+(?::[0-9]+)?\)$');
final RegExp packageParser = new RegExp(r'^([^:]+):(.+)$');
final List<String> result = <String>[];
final List<String> skipped = <String>[];

5
packages/flutter/lib/src/material/page.dart
View file

@ -70,9 +70,8 @@ class MaterialPageRoute<T> extends PageRoute<T> {
this.maintainState: true,
bool fullscreenDialog: false,
}) : assert(builder != null),
super(settings: settings, fullscreenDialog: fullscreenDialog) {
assert(opaque);
}
assert(opaque),
super(settings: settings, fullscreenDialog: fullscreenDialog);
/// Builds the primary contents of the route.
final WidgetBuilder builder;

5
packages/flutter/lib/src/widgets/pages.dart
View file

@ -81,11 +81,10 @@ class PageRouteBuilder<T> extends PageRoute<T> {
this.maintainState: true,
}) : assert(pageBuilder != null),
assert(transitionsBuilder != null),
assert(opaque != null),
assert(barrierDismissible != null),
assert(maintainState != null),
super(settings: settings) {
assert(opaque != null);
}
super(settings: settings);
/// Used build the route's primary contents.
///