Resolve 113705: Separated longer running tests from runMisc to prevent flakiness from timeouts (#113784)

This commit is contained in:
pdblasi-google 2022-10-21 09:02:14 -07:00 committed by GitHub
parent 07319a9868
commit 782baecc50
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 39 additions and 4 deletions

View file

@ -377,6 +377,32 @@ targets:
- bin/
- .ci.yaml
- name: Linux framework_tests_slow
bringup: true
recipe: flutter/flutter_drone
timeout: 60
properties:
dependencies: >-
[
{"dependency": "android_sdk", "version": "version:33v6"}
]
shard: framework_tests
subshard: slow
tags: >
["framework", "hostonly", "shard", "linux"]
runIf:
- dev/
- packages/flutter/
- packages/flutter_driver/
- packages/integration_test/
- packages/flutter_localizations/
- packages/fuchsia_remote_debug_protocol/
- packages/flutter_test/
- packages/flutter_goldens/
- packages/flutter_tools/
- bin/
- .ci.yaml
- name: Linux framework_tests_misc
recipe: flutter/flutter_drone
timeout: 60

View file

@ -965,6 +965,17 @@ Future<void> _runFrameworkTests() async {
);
}
// Tests that take longer than average to run. This is usually because they
// need to compile something large or make use of the analyzer for the test.
// These tests need to be platform agnostic as they are only run on a linux
// machine to save on execution time and cost.
Future<void> runSlow() async {
printProgress('${green}Running slow package tests$reset for directories other than packages/flutter');
await runTracingTests();
await runFixTests();
await runPrivateTests();
}
Future<void> runMisc() async {
printProgress('${green}Running package tests$reset for directories other than packages/flutter');
await _runTestHarnessTests();
@ -972,7 +983,7 @@ Future<void> _runFrameworkTests() async {
await _runDartTest(path.join(flutterRoot, 'dev', 'bots'));
await _runDartTest(path.join(flutterRoot, 'dev', 'devicelab'), ensurePrecompiledTool: false); // See https://github.com/flutter/flutter/issues/86209
await _runDartTest(path.join(flutterRoot, 'dev', 'conductor', 'core'), forceSingleCore: true);
// TODO(gspencergoog): Remove the exception for fatalWarnings once https://github.com/flutter/flutter/pull/91127 has landed.
// TODO(gspencergoog): Remove the exception for fatalWarnings once https://github.com/flutter/flutter/issues/113782 has landed.
await _runFlutterTest(path.join(flutterRoot, 'dev', 'integration_tests', 'android_semantics_testing'), fatalWarnings: false);
await _runFlutterTest(path.join(flutterRoot, 'dev', 'integration_tests', 'ui'));
await _runFlutterTest(path.join(flutterRoot, 'dev', 'manual_tests'));
@ -991,9 +1002,6 @@ Future<void> _runFrameworkTests() async {
await _runFlutterTest(path.join(flutterRoot, 'packages', 'flutter_test'), options: soundNullSafetyOptions);
await _runFlutterTest(path.join(flutterRoot, 'packages', 'fuchsia_remote_debug_protocol'), options: soundNullSafetyOptions);
await _runFlutterTest(path.join(flutterRoot, 'dev', 'integration_tests', 'non_nullable'), options: mixedModeNullSafetyOptions);
await runTracingTests();
await runFixTests();
await runPrivateTests();
const String httpClientWarning =
'Warning: At least one test in this suite creates an HttpClient. When\n'
'running a test suite that uses TestWidgetsFlutterBinding, all HTTP\n'
@ -1023,6 +1031,7 @@ Future<void> _runFrameworkTests() async {
await selectSubshard(<String, ShardRunner>{
'widgets': runWidgets,
'libraries': runLibraries,
'slow': runSlow,
'misc': runMisc,
});
}