development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-08-24 18:36:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Dispose precached image info (#143017)

Browse source 
`precacheImage` was failing to dipose the `ImageInfo` it receives. That's part of the contract of being an image listener.

I'm doing this in the frame callback for the same reason as evicting it from the cache.
This commit is contained in:
Dan Field 2024-02-06 19:28:06 -08:00 committed by GitHub
parent ac5c3dec87
commit 7514c16a6a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/flutter/lib/src/widgets/image.dart
View file

@ -123,6 +123,7 @@ Future<void> precacheImage(
// image stream.
// See ImageCache._liveImages
SchedulerBinding.instance.addPostFrameCallback((Duration timeStamp) {
image?.dispose();
stream.removeListener(listener!);
}, debugLabel: 'precacheImage.removeListener');
},

14
packages/flutter/test/widgets/image_test.dart
View file

@ -798,8 +798,6 @@ void main() {
});
testWidgets('Precache',
// TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787 [leaks-to-clean]
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
(WidgetTester tester) async {
final _TestImageProvider provider = _TestImageProvider();
late Future<void> precache;
@ -818,7 +816,10 @@ void main() {
// Check that a second resolve of the same image is synchronous.
final ImageStream stream = provider.resolve(provider._lastResolvedConfiguration);
late bool isSync;
stream.addListener(ImageStreamListener((ImageInfo image, bool sync) { isSync = sync; }));
stream.addListener(ImageStreamListener((ImageInfo image, bool sync) {
image.dispose();
isSync = sync;
}));
expect(isSync, isTrue);
});
@ -1565,8 +1566,6 @@ void main() {
});
testWidgets('precacheImage does not hold weak ref for more than a frame',
// TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787 [leaks-to-clean]
experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
(WidgetTester tester) async {
imageCache.maximumSize = 0;
final _TestImageProvider provider = _TestImageProvider();
@ -1597,7 +1596,10 @@ void main() {
expect(provider._lastResolvedConfiguration, isNotNull);
final ImageStream stream = provider.resolve(provider._lastResolvedConfiguration);
late bool isSync;
final ImageStreamListener listener = ImageStreamListener((ImageInfo image, bool syncCall) { isSync = syncCall; });
final ImageStreamListener listener = ImageStreamListener((ImageInfo image, bool syncCall) {
image.dispose();
isSync = syncCall;
});
// Still have live ref because frame has not pumped yet.
await tester.pump();