development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-05 15:59:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add stateful reordering test for TwoDimensionalViewport (#142375)

Browse source 
Adds a test to validate state is preserved after reordering in `TwoDimensionalViewport` (reference: https://github.com/flutter/flutter/pull/141504#pullrequestreview-1837501775).

- Fixes #130754
This commit is contained in:
Amir Panahandeh 2024-03-01 02:33:53 +03:30 committed by GitHub
parent 203ec8b837
commit 6068891373
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 50 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
packages/flutter/test/widgets/two_dimensional_viewport_test.dart
View file

@ -2759,6 +2759,56 @@ void main() {
expect(tester.getRect(find.byKey(const ValueKey<int>(1))),
const Rect.fromLTWH(200.0, 200.0, 200.0, 200.0));
}, variant: TargetPlatformVariant.all());
testWidgets('state is preserved after reordering',
(WidgetTester tester) async {
final TwoDimensionalChildBuilderDelegate delegate1 =
TwoDimensionalChildBuilderDelegate(
maxXIndex: 5,
maxYIndex: 5,
addAutomaticKeepAlives: false,
addRepaintBoundaries: false,
builder: (BuildContext context, ChildVicinity vicinity) {
ValueKey<int>? key;
if (vicinity == const ChildVicinity(xIndex: 1, yIndex: 1)) {
key = const ValueKey<int>(1);
} else if (vicinity ==
const ChildVicinity(xIndex: 1, yIndex: 2)) {
key = const ValueKey<int>(2);
}
return Checkbox(key: key, value: false, onChanged: (_) {});
});
final TwoDimensionalChildBuilderDelegate delegate2 =
TwoDimensionalChildBuilderDelegate(
maxXIndex: 5,
maxYIndex: 5,
addAutomaticKeepAlives: false,
addRepaintBoundaries: false,
builder: (BuildContext context, ChildVicinity vicinity) {
ValueKey<int>? key;
if (vicinity == const ChildVicinity(xIndex: 0, yIndex: 0)) {
key = const ValueKey<int>(1);
} else if (vicinity ==
const ChildVicinity(xIndex: 1, yIndex: 1)) {
key = const ValueKey<int>(2);
}
return Checkbox(key: key, value: false, onChanged: (_) {});
});
addTearDown(delegate1.dispose);
addTearDown(delegate2.dispose);
await tester.pumpWidget(simpleBuilderTest(delegate: delegate1));
final State stateBeforeReordering =
tester.state(find.byKey(const ValueKey<int>(2)));
await tester.pumpWidget(simpleBuilderTest(delegate: delegate2));
expect(tester.state(find.byKey(const ValueKey<int>(2))),
stateBeforeReordering);
await tester.pumpWidget(simpleBuilderTest(delegate: delegate1));
expect(tester.state(find.byKey(const ValueKey<int>(2))),
stateBeforeReordering);
}, variant: TargetPlatformVariant.all());
});
}