development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-07-16 10:29:14 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Remove deprecated KeepAliveHandle.release (#143961)

Browse source 
https://github.com/flutter/flutter/issues/143956

I still did not include a dartfix since a dartfix that replaces `release` with `dispose` would change the semantics and may cause a runtime crash instead of a build error.

@Piinks  does setting `bulkApply` to false force the user to apply the fix to every occurrence one by one in their IDE? If so then it seems that would be the way to go for this deprecation?
This commit is contained in:
LongCatIsLooong 2024-02-22 19:16:20 -08:00 committed by GitHub
parent 10a50bcc7a
commit 59da873ef0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
packages/flutter/lib/src/widgets/automatic_keep_alive.dart
View file

@ -319,19 +319,6 @@ class KeepAliveNotification extends Notification {
/// consider using [AutomaticKeepAliveClientMixin], which uses a
/// [KeepAliveHandle] internally.
class KeepAliveHandle extends ChangeNotifier {
/// Trigger the listeners to indicate that the widget
/// no longer needs to be kept alive.
///
/// This method does not call [dispose]. When the handle is not needed
/// anymore, it must be [dispose]d regardless of whether notifying listeners.
@Deprecated(
'Use dispose instead. '
'This feature was deprecated after v3.3.0-0.0.pre.',
)
void release() {
notifyListeners();
}
@override
void dispose() {
notifyListeners();
@ -366,7 +353,6 @@ mixin AutomaticKeepAliveClientMixin<T extends StatefulWidget> on State<T> {
}
void _releaseKeepAlive() {
// Dispose and release do not imply each other.
_keepAliveHandle!.dispose();
_keepAliveHandle = null;
}