From 5376e90fdaaf9d9c799de60e57542d7caa4bb849 Mon Sep 17 00:00:00 2001 From: Danny Tuppeny Date: Thu, 14 Nov 2019 17:54:22 +0000 Subject: [PATCH] Print a message when modifying settings that you may need to reload IDE/editor (#44574) * Print a message when modifying settings that you may need to reload IDEs/editors * Add a test for `flutter config` output * Remove blank line --- .../flutter_tools/lib/src/commands/config.dart | 2 ++ .../test/commands.shard/hermetic/config_test.dart | 15 +++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/packages/flutter_tools/lib/src/commands/config.dart b/packages/flutter_tools/lib/src/commands/config.dart index 46a73bdd8e8..02895d8c084 100644 --- a/packages/flutter_tools/lib/src/commands/config.dart +++ b/packages/flutter_tools/lib/src/commands/config.dart @@ -154,6 +154,8 @@ class ConfigCommand extends FlutterCommand { if (argResults.arguments.isEmpty) { printStatus(usage); + } else { + printStatus('\nYou may need to restart any open editors for them to read new settings.'); } return null; diff --git a/packages/flutter_tools/test/commands.shard/hermetic/config_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/config_test.dart index d5b79b7e515..24c0e850c27 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/config_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/config_test.dart @@ -155,6 +155,21 @@ void main() { Usage: () => mockUsage, }); + testUsingContext('warns the user to reload IDE', () async { + final BufferLogger logger = context.get(); + final ConfigCommand configCommand = ConfigCommand(); + final CommandRunner commandRunner = createTestCommandRunner(configCommand); + + await commandRunner.run([ + 'config', + '--enable-web' + ]); + + expect(logger.statusText, contains('You may need to restart any open editors')); + }, overrides: { + Usage: () => mockUsage, + }); + testUsingContext('displays which config settings are available on stable', () async { final BufferLogger logger = context.get(); when(mockFlutterVersion.channel).thenReturn('stable');