From 50ed8a34b005e605691e619c0fd15d093a42d2b3 Mon Sep 17 00:00:00 2001
From: Michael Goderbauer <goderbauer@google.com>
Date: Tue, 24 Jan 2023 13:24:11 -0800
Subject: [PATCH] Enable `unnecessary_null_comparison` check (#118849)

* Enable unnecessary_null_comparison outside of packages

* fix snippet

* enable for all
---
 analysis_options.yaml                       | 2 --
 packages/flutter/lib/src/rendering/box.dart | 1 -
 2 files changed, 3 deletions(-)

diff --git a/analysis_options.yaml b/analysis_options.yaml
index c88c8521dac..565b00a1f09 100644
--- a/analysis_options.yaml
+++ b/analysis_options.yaml
@@ -23,8 +23,6 @@ analyzer:
     # allow self-reference to deprecated members (we do this because otherwise we have
     # to annotate every member in every test, assert, etc, when we deprecate something)
     deprecated_member_use_from_same_package: ignore
-    # Turned off until null-safe rollout is complete.
-    unnecessary_null_comparison: ignore
   exclude:
     - "bin/cache/**"
       # Ignore protoc generated files
diff --git a/packages/flutter/lib/src/rendering/box.dart b/packages/flutter/lib/src/rendering/box.dart
index c7fed17c55e..1090c869e27 100644
--- a/packages/flutter/lib/src/rendering/box.dart
+++ b/packages/flutter/lib/src/rendering/box.dart
@@ -987,7 +987,6 @@ class _IntrinsicDimensionsCacheEntry {
 /// AxisDirection get axis => _axis;
 /// AxisDirection _axis = AxisDirection.down; // or initialized in constructor
 /// set axis(AxisDirection value) {
-///   assert(value != null); // same checks as in the constructor
 ///   if (value == _axis) {
 ///     return;
 ///   }