development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

CupertinoDialogAction is missing super call (#42924)

Browse source
This commit is contained in:
Daniel 2019-10-24 04:30:01 +02:00 committed by LongCatIsLooong
parent 42d319720b
commit 4c2c17986a
2 changed files with 33 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/flutter/lib/src/cupertino/dialog.dart
View file

@ -1039,6 +1039,7 @@ class _ActionButtonParentData extends MultiChildLayoutParentData {
class CupertinoDialogAction extends StatelessWidget {
/// Creates an action for an iOS-style dialog.
const CupertinoDialogAction({
Key key,
this.onPressed,
this.isDefaultAction = false,
this.isDestructiveAction = false,
@ -1046,7 +1047,8 @@ class CupertinoDialogAction extends StatelessWidget {
@required this.child,
}) : assert(child != null),
assert(isDefaultAction != null),
assert(isDestructiveAction != null);
assert(isDestructiveAction != null),
super(key: key);
/// The callback that is called when the button is tapped or otherwise
/// activated.

30
packages/flutter/test/cupertino/dialog_test.dart
View file

@ -1023,6 +1023,36 @@ void main() {
transition = tester.widgetList(find.byType(FadeTransition)).elementAt(1);
expect(transition.opacity.value, closeTo(0.0, 0.001));
});
testWidgets('Actions are accessible by key', (WidgetTester tester) async {
await tester.pumpWidget(
createAppWithButtonThatLaunchesDialog(
dialogBuilder: (BuildContext context) {
return const CupertinoAlertDialog(
title: Text('The Title'),
content: Text('The message'),
actions: <Widget>[
CupertinoDialogAction(
key: Key('option_1'),
child: Text('Option 1'),
),
CupertinoDialogAction(
key: Key('option_2'),
child: Text('Option 2'),
),
],
);
},
),
);
await tester.tap(find.text('Go'));
await tester.pump();
expect(find.byKey(const Key('option_1')), findsOneWidget);
expect(find.byKey(const Key('option_2')), findsOneWidget);
expect(find.byKey(const Key('option_3')), findsNothing);
});
}
RenderBox findActionButtonRenderBoxByTitle(WidgetTester tester, String title) {