development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 19:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use "measured_frame" instead of "CrRendererMain" to detect process ID (#53969)

Browse source
This commit is contained in:
Yegor 2020-04-03 16:51:44 -07:00 committed by GitHub
parent 5c69785b16
commit 4b92c16755
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
dev/devicelab/lib/framework/browser.dart
View file

@ -281,11 +281,26 @@ class BlinkTraceSummary {
.toList()
..sort((BlinkTraceEvent a, BlinkTraceEvent b) => a.ts - b.ts);
// Use the pid from the first "measured_frame" event since the event is
// emitted by the script running on the process we're interested in.
//
// We previously tried using the "CrRendererMain" event. However, for
// reasons unknown, Chrome in the devicelab refuses to emit this event
// sometimes, causing to flakes.
final BlinkTraceEvent firstMeasuredFrameEvent = events.firstWhere(
(BlinkTraceEvent event) => event.isBeginMeasuredFrame,
orElse: () => null,
);
if (firstMeasuredFrameEvent == null) {
// This happens in benchmarks that do not measure frames, such as some
// of the text layout benchmarks.
return null;
}
final int tabPid = firstMeasuredFrameEvent.pid;
// Filter out data from unrelated processes
final BlinkTraceEvent processLabel = events
.where((BlinkTraceEvent event) => event.isCrRendererMain)
.single;
final int tabPid = processLabel.pid;
events = events.where((BlinkTraceEvent element) => element.pid == tabPid).toList();
// Extract frame data.
@ -489,14 +504,6 @@ class BlinkTraceEvent {
/// This event is a duration event that has its `tdur` populated.
bool get isUpdateAllLifecyclePhases => ph == 'X' && name == 'WebViewImpl::updateAllLifecyclePhases';
/// A "CrRendererMain" event contains information about the browser's UI
/// thread.
///
/// This event's [pid] field identifies the process that performs web page
/// rendering. The [isBeginFrame] and [isUpdateAllLifecyclePhases] events
/// with the same [pid] as this event all belong to the same web page.
bool get isCrRendererMain => name == 'thread_name' && args['name'] == 'CrRendererMain';
/// Whether this is the beginning of a "measured_frame" event.
///
/// This event is a custom event emitted by our benchmark test harness.