development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

allow todos in user code to show in IDEs (#23303)

Browse source
This commit is contained in:
Devon Carew 2018-10-19 14:10:54 -07:00 committed by GitHub
parent de9f18d288
commit 48fe65c236
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 20 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/flutter/lib/analysis_options_user.yaml
View file

@ -24,8 +24,6 @@ analyzer:
errors:
# treat missing required parameters as a warning (not a hint)
missing_required_param: warning
# allow having TODOs in the code
todo: ignore
linter:
rules:

3
packages/flutter_tools/lib/src/commands/analyze_once.dart
View file

@ -87,7 +87,8 @@ class AnalyzeOnce extends AnalyzeBase {
}
});
server.onErrors.listen((FileAnalysisErrors fileErrors) {
errors.addAll(fileErrors.errors);
// Record the issues found (but filter out to do comments).
errors.addAll(fileErrors.errors.where((AnalysisError error) => error.type != 'TODO'));
});
await server.start();

18
packages/flutter_tools/test/commands/analyze_once_test.dart
View file

@ -178,6 +178,24 @@ StringBuffer bar = StringBuffer('baz');
tryToDelete(tempDir);
}
});
testUsingContext('returns no issues for todo comments', () async {
const String contents = '''
// TODO(foobar):
StringBuffer bar = StringBuffer('baz');
''';
final Directory tempDir = fs.systemTempDirectory.createTempSync('flutter_analyze_once_test_4.');
tempDir.childFile('main.dart').writeAsStringSync(contents);
try {
await runCommand(
command: AnalyzeCommand(workingDirectory: fs.directory(tempDir)),
arguments: <String>['analyze'],
statusTextContains: <String>['No issues found!'],
);
} finally {
tryToDelete(tempDir);
}
});
});
}