development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Flip the default for proguard (#40282)

Browse source
This commit is contained in:
Emmanuel Garcia 2019-09-11 17:51:51 -07:00 committed by GitHub
parent 07dad46607
commit 3712ea63d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/flutter_tools/lib/src/commands/build_apk.dart
View file

@ -30,7 +30,7 @@ class BuildApkCommand extends BuildSubCommand {
)
..addFlag('proguard',
negatable: true,
defaultsTo: true,
defaultsTo: false,
help: 'Whether to enable Proguard on release mode. '
'To learn more, see: https://flutter.dev/docs/deployment/android#enabling-proguard',
)

2
packages/flutter_tools/lib/src/commands/build_appbundle.dart
View file

@ -24,7 +24,7 @@ class BuildAppBundleCommand extends BuildSubCommand {
..addFlag('track-widget-creation', negatable: false, hide: !verboseHelp)
..addFlag('proguard',
negatable: true,
defaultsTo: true,
defaultsTo: false,
help: 'Whether to enable Proguard on release mode. '
'To learn more, see: https://flutter.dev/docs/deployment/android#enabling-proguard',
)

3
packages/flutter_tools/test/general.shard/commands/build_apk_test.dart
View file

@ -165,6 +165,7 @@ void main() {
GradleUtils: () => GradleUtils(),
ProcessManager: () => mockProcessManager,
},
skip: true,
timeout: allowForCreateFlutterProject);
testUsingContext('proguard is disabled when --no-proguard is passed', () async {
@ -197,6 +198,7 @@ void main() {
GradleUtils: () => GradleUtils(),
ProcessManager: () => mockProcessManager,
},
skip: true,
timeout: allowForCreateFlutterProject);
testUsingContext('guides the user when proguard fails', () async {
@ -255,6 +257,7 @@ void main() {
ProcessManager: () => mockProcessManager,
Usage: () => mockUsage,
},
skip: true,
timeout: allowForCreateFlutterProject);
});
}

3
packages/flutter_tools/test/general.shard/commands/build_appbundle_test.dart
View file

@ -152,6 +152,7 @@ void main() {
GradleUtils: () => GradleUtils(),
ProcessManager: () => mockProcessManager,
},
skip: true,
timeout: allowForCreateFlutterProject);
testUsingContext('proguard is disabled when --no-proguard is passed', () async {
@ -186,6 +187,7 @@ void main() {
GradleUtils: () => GradleUtils(),
ProcessManager: () => mockProcessManager,
},
skip: true,
timeout: allowForCreateFlutterProject);
testUsingContext('guides the user when proguard fails', () async {
@ -244,6 +246,7 @@ void main() {
ProcessManager: () => mockProcessManager,
Usage: () => mockUsage,
},
skip: true,
timeout: allowForCreateFlutterProject);
});
}