mirror of
https://github.com/flutter/flutter
synced 2024-10-14 04:02:56 +00:00
Fix issues found running tests
//mobile/flutter/tests/app:basic_runner_test_* during a google3 roll. The following exception was being thrown _TypeError: type 'String' is not a subtype of type 'File' ``` 8) <asynchronous suspension> utter_command.dart:347:18) <asynchronous suspension> /flutter_command.dart:282:33) <asynchronous suspension> xt.dart:142:29) <asynchronous suspension>
This commit is contained in:
parent
b280074815
commit
35d50a0e16
|
@ -364,13 +364,16 @@ class RunCommand extends RunCommandBase {
|
|||
}).toList();
|
||||
|
||||
ResidentRunner runner;
|
||||
final String applicationBinaryPath = argResults['use-application-binary'];
|
||||
if (hotMode) {
|
||||
runner = new HotRunner(
|
||||
flutterDevices,
|
||||
target: targetFile,
|
||||
debuggingOptions: _createDebuggingOptions(),
|
||||
benchmarkMode: argResults['benchmark'],
|
||||
applicationBinary: argResults['use-application-binary'],
|
||||
applicationBinary: applicationBinaryPath == null
|
||||
? null
|
||||
: fs.file(applicationBinaryPath),
|
||||
projectRootPath: argResults['project-root'],
|
||||
packagesFilePath: globalResults['packages'],
|
||||
dillOutputPath: argResults['output-dill'],
|
||||
|
@ -383,7 +386,9 @@ class RunCommand extends RunCommandBase {
|
|||
target: targetFile,
|
||||
debuggingOptions: _createDebuggingOptions(),
|
||||
traceStartup: traceStartup,
|
||||
applicationBinary: argResults['use-application-binary'],
|
||||
applicationBinary: applicationBinaryPath == null
|
||||
? null
|
||||
: fs.file(applicationBinaryPath),
|
||||
stayResident: stayResident,
|
||||
ipv6: ipv6,
|
||||
);
|
||||
|
|
Loading…
Reference in a new issue