Remove redundant rootDirectoryPath parameter in DevFS::update (#143034)

Resolves #143041
This commit is contained in:
Andrew Kolos 2024-02-07 10:04:31 -08:00 committed by GitHub
parent 8e2da8414c
commit 34c2080b9d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 1 additions and 6 deletions

View file

@ -570,7 +570,6 @@ class DevFS {
DateTime? firstBuildTime,
bool bundleFirstUpload = false,
bool fullRestart = false,
String? projectRootPath,
File? dartPluginRegistrant,
}) async {
final DateTime candidateCompileTime = DateTime.now();
@ -598,7 +597,7 @@ class DevFS {
invalidatedFiles,
outputPath: dillOutputPath,
fs: _fileSystem,
projectRootPath: projectRootPath,
projectRootPath: rootDirectory?.path,
packageConfig: packageConfig,
checkDartPluginRegistry: true, // The entry point is assumed not to have changed.
dartPluginRegistrant: dartPluginRegistrant,

View file

@ -569,7 +569,6 @@ Please provide a valid TCP port (an integer between 0 and 65535, inclusive).
generator: device!.generator!,
fullRestart: fullRestart,
dillOutputPath: dillOutputPath,
projectRootPath: projectRootPath,
pathToReload: getReloadPath(fullRestart: fullRestart, swap: false),
invalidatedFiles: invalidationResult.uris!,
packageConfig: invalidationResult.packageConfig!,

View file

@ -560,7 +560,6 @@ class FlutterDevice {
bool bundleFirstUpload = false,
bool bundleDirty = false,
bool fullRestart = false,
String? projectRootPath,
required String pathToReload,
required String dillOutputPath,
required List<Uri> invalidatedFiles,
@ -581,7 +580,6 @@ class FlutterDevice {
fullRestart: fullRestart,
dillOutputPath: dillOutputPath,
trackWidgetCreation: buildInfo.trackWidgetCreation,
projectRootPath: projectRootPath,
pathToReload: pathToReload,
invalidatedFiles: invalidatedFiles,
packageConfig: packageConfig,

View file

@ -542,7 +542,6 @@ class HotRunner extends ResidentRunner {
bundleFirstUpload: isFirstUpload,
bundleDirty: !isFirstUpload && rebuildBundle,
fullRestart: fullRestart,
projectRootPath: projectRootPath,
pathToReload: getReloadPath(fullRestart: fullRestart, swap: _swap),
invalidatedFiles: invalidationResult.uris!,
packageConfig: invalidationResult.packageConfig!,