development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-14 04:02:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes crossAxisSpacing overflow in RTL (#27945)

Browse source
This commit is contained in:
Ali EP 2019-02-21 03:13:01 +03:30 committed by Michael Goderbauer
parent d1136e3109
commit 307848953f
2 changed files with 29 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/flutter/lib/src/rendering/sliver_grid.dart
View file

@ -207,7 +207,7 @@ class SliverGridRegularTileLayout extends SliverGridLayout {
double _getOffsetFromStartInCrossAxis(double crossAxisStart) {
if (reverseCrossAxis)
return crossAxisCount * crossAxisStride - crossAxisStart - childCrossAxisExtent;
return crossAxisCount * crossAxisStride - crossAxisStart - childCrossAxisExtent - (crossAxisStride - childCrossAxisExtent);
return crossAxisStart;
}

28
packages/flutter/test/widgets/grid_view_test.dart
View file

@ -536,4 +536,32 @@ void main() {
expect(tester.getTopLeft(find.byKey(target)), const Offset(600.0, 0.0));
expect(tester.getBottomRight(find.byKey(target)), const Offset(800.0, 200.0));
});
testWidgets('GridView crossAxisSpacing', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/27151.
final Key target = UniqueKey();
Widget build(TextDirection textDirection) {
return Directionality(
textDirection: textDirection,
child: GridView.count(
crossAxisCount: 4,
crossAxisSpacing: 8.0,
children: <Widget>[
Container(key: target),
],
),
);
}
await tester.pumpWidget(build(TextDirection.ltr));
expect(tester.getTopLeft(find.byKey(target)), Offset.zero);
expect(tester.getBottomRight(find.byKey(target)), const Offset(194.0, 194.0));
await tester.pumpWidget(build(TextDirection.rtl));
expect(tester.getTopLeft(find.byKey(target)), const Offset(606.0, 0.0));
expect(tester.getBottomRight(find.byKey(target)), const Offset(800.0, 194.0));
});
}