development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-16 05:02:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix aot_snapshot_size_* benchmarks (#18520)

Browse source 
... and make sure they fail if they can't report the size.
This commit is contained in:
Michael Goderbauer 2018-06-15 17:17:28 -07:00 committed by GitHub
parent 0fa5ba43a1
commit 2a19dae28b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
dev/devicelab/lib/tasks/perf_tests.dart
View file

@ -228,6 +228,7 @@ class CompileTest {
final List<String> options = <String>[
'aot',
'-v',
'--extra-gen-snapshot-options=--print_snapshot_sizes',
'--release',
'--no-pub',
'--target-platform',
@ -253,6 +254,9 @@ class CompileTest {
for (Match m in metricExpression.allMatches(compileLog)) {
metrics[_sdkNameToMetricName(m.group(1))] = int.parse(m.group(2));
}
if (metrics.length != _kSdkNameToMetricNameMapping.length) {
throw 'Expected metrics: ${_kSdkNameToMetricNameMapping.keys}, but got: ${metrics.keys}.';
}
metrics['aot_snapshot_compile_millis'] = watch.elapsedMilliseconds;
return metrics;
@ -326,19 +330,20 @@ class CompileTest {
};
}
static String _sdkNameToMetricName(String sdkName) {
const Map<String, String> kSdkNameToMetricNameMapping = const <String, String> {
'VMIsolate': 'aot_snapshot_size_vmisolate',
'Isolate': 'aot_snapshot_size_isolate',
'ReadOnlyData': 'aot_snapshot_size_rodata',
'Instructions': 'aot_snapshot_size_instructions',
'Total': 'aot_snapshot_size_total',
};
static const Map<String, String> _kSdkNameToMetricNameMapping = const <String, String> {
'VMIsolate': 'aot_snapshot_size_vmisolate',
'Isolate': 'aot_snapshot_size_isolate',
'ReadOnlyData': 'aot_snapshot_size_rodata',
'Instructions': 'aot_snapshot_size_instructions',
'Total': 'aot_snapshot_size_total',
};
if (!kSdkNameToMetricNameMapping.containsKey(sdkName))
static String _sdkNameToMetricName(String sdkName) {
if (!_kSdkNameToMetricNameMapping.containsKey(sdkName))
throw 'Unrecognized SDK snapshot metric name: $sdkName';
return kSdkNameToMetricNameMapping[sdkName];
return _kSdkNameToMetricNameMapping[sdkName];
}
}