development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

AlertDialog widget scrollable by default (#49848)

Browse source
This commit is contained in:
Shi-Hao Hong 2020-03-03 13:39:01 -08:00 committed by GitHub
parent e491544588
commit 28f2c96a8a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/flutter/lib/src/material/dialog.dart
View file

@ -259,7 +259,7 @@ class AlertDialog extends StatelessWidget {
this.insetPadding = _defaultInsetPadding,
this.clipBehavior = Clip.none,
this.shape,
this.scrollable = false,
this.scrollable = true,
}) : assert(contentPadding != null),
assert(clipBehavior != null),
super(key: key);

3
packages/flutter/test/material/dialog_test.dart
View file

@ -1100,7 +1100,6 @@ void main() {
color: Colors.green,
height: 1000,
),
scrollable: true,
);
await tester.pumpWidget(_buildAppWithDialog(dialog));
await tester.tap(find.text('X'));
@ -1120,7 +1119,6 @@ void main() {
color: Colors.orange,
height: 1000,
),
scrollable: true,
);
await tester.pumpWidget(_buildAppWithDialog(dialog));
await tester.tap(find.text('X'));
@ -1146,7 +1144,6 @@ void main() {
color: Colors.orange,
height: 400,
),
scrollable: true,
);
await tester.pumpWidget(_buildAppWithDialog(dialog));
await tester.tap(find.text('X'));