development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-02 22:44:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix invalid URL suggestion for gradle incompatability (#150999)

Browse source 
The current URL has 2 /to, but it should only be 1. However, this url redirects to https://docs.flutter.dev/release/breaking-changes/android-java-gradle-migration-guide, so I can change it to that if it's preferred just to go to the final destination - just don't know if it's a redirect for a reason

i didn't create an issue as it's a doc change, but if that's a requirement I can do that
This commit is contained in:
Aaron Housh 2024-07-03 13:38:11 -07:00 committed by GitHub
parent 6e246ac854
commit 25b72bab18
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/flutter_tools/lib/src/android/gradle_errors.dart
View file

@ -592,7 +592,7 @@ final GradleHandledError incompatibleJavaAndGradleVersionsHandler = GradleHandle
"${globals.logger.terminal.warningMark} Your project's Gradle version "
'is incompatible with the Java version that Flutter is using for Gradle.\n\n'
'If you recently upgraded Android Studio, consult the migration guide '
'at https://flutter.dev/to/to/java-gradle-incompatibility.\n\n'
'at https://flutter.dev/to/java-gradle-incompatibility.\n\n'
'Otherwise, to fix this issue, first, check the Java version used by Flutter by '
'running `flutter doctor --verbose`.\n\n'
'Then, update the Gradle version specified in ${gradlePropertiesFile.path} '

2
packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart
View file

@ -1256,7 +1256,7 @@ Could not compile build file '…/example/android/build.gradle'.
// Ensure the error notes the incompatible Gradle/AGP/Java versions, links to related resources,
// and a portion of the path to where to change their gradle version.
expect(testLogger.statusText, contains('Gradle version is incompatible with the Java version'));
expect(testLogger.statusText, contains('flutter.dev/to/to/java-gradle-incompatibility'));
expect(testLogger.statusText, contains('flutter.dev/to/java-gradle-incompatibility'));
expect(testLogger.statusText, contains('gradle-wrapper.properties'));
expect(testLogger.statusText, contains('https://docs.gradle.org/current/userguide/compatibility.html#java'));
}, overrides: <Type, Generator>{