development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-12 19:23:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_tools] Remove exception for chain stack traces for Integration Tests (#79618)

Browse source
This commit is contained in:
Jia Hao 2021-04-03 05:54:03 +08:00 committed by GitHub
parent 768fcb1f0a
commit 23015dc501
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
dev/automated_tests/integration_test/exception_handling_expectation.txt
View file

@ -30,7 +30,7 @@ The following message was thrown running a test:
Who lives, who dies, who tells your story\?
When the exception was thrown, this was the stack:
.*(TODO\(jiahaog\): Remove --no-chain-stack-traces and replace this with the actual stack once https://github.com/dart-lang/stack_trace/issues/106 is fixed)?
#2 main.<anonymous closure> \(.+[/\\]dev[/\\]automated_tests[/\\]integration_test[/\\]exception_handling_test\.dart:16:5\)
<<skip until matching line>>
The test description was:
Exception handling in test harness - uncaught Future error

7
packages/flutter_tools/lib/src/test/runner.dart
View file

@ -183,13 +183,6 @@ class _FlutterTestRunnerImpl implements FlutterTestRunner {
return exitCode;
}
if (integrationTestDevice != null) {
// Without this, some async exceptions which are caught will surface when
// debugging tests.
// TODO(jiahaog): Remove this once https://github.com/dart-lang/stack_trace/issues/106 is fixed.
testArgs.add('--no-chain-stack-traces');
}
testArgs
..add('--')
..addAll(testFiles);

1
packages/flutter_tools/test/commands.shard/hermetic/test_test.dart
View file

@ -331,7 +331,6 @@ dev_dependencies:
]);
expect(fakePackageTest.lastArgs, contains('--concurrency=1'));
expect(fakePackageTest.lastArgs, contains('--no-chain-stack-traces'));
}, overrides: <Type, Generator>{
FileSystem: () => fs,
ProcessManager: () => FakeProcessManager.any(),