development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-02 14:34:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

[GAR] [a11y] Update text button page in a11y assessment app (#148905)

Browse source 
internal: b/317125569

If the text button label contains its role and state, it will be confusing for tester.

it will be announced like "xxx button button" :

<img src="https://github.com/flutter/flutter/assets/108393416/16f5a996-b0f1-4f04-bd99-caa3cacd4182" width=50% height=50%> 

updated screen and label: 
<img src="https://github.com/flutter/flutter/assets/108393416/1de55cec-8a18-4c36-9dac-84ae7d151fd6" width=50% height=50%>
This commit is contained in:
hangyu 2024-05-30 11:34:07 -07:00 committed by GitHub
parent 54573bc875
commit 1aba3a66f5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 19 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
dev/a11y_assessments/lib/use_cases/text_button.dart
View file

@ -39,13 +39,25 @@ class MainWidgetState extends State<MainWidget> {
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
TextButton(
onPressed: () { },
child: const Text('Text button'),
Row(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
const Text('This is a TextButton:'),
TextButton(
onPressed: () { },
child: const Text('Action'),
),
],
),
const TextButton(
onPressed: null,
child: Text('Text button disabled'),
const Row(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Text('This is a disabled TextButton:'),
TextButton(
onPressed: null,
child: Text('Action'),
),
],
),
],
),

3
dev/a11y_assessments/test/text_button_test.dart
View file

@ -10,7 +10,6 @@ import 'test_utils.dart';
void main() {
testWidgets('text button can run', (WidgetTester tester) async {
await pumpsUseCase(tester, TextButtonUseCase());
expect(find.text('Text button'), findsOneWidget);
expect(find.text('Text button disabled'), findsOneWidget);
expect(find.text('Action'), findsExactly(2));
});
}