development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove workaround now that type promotion accounts for local boolean variables. (#74449)

Browse source
This commit is contained in:
Paul Berry 2021-01-22 16:34:06 -08:00 committed by GitHub
parent 0b3162bd9c
commit 177fd261bb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/flutter/lib/src/widgets/scrollable.dart
View file

@ -982,16 +982,6 @@ class ScrollAction extends Action<ScrollIntent> {
final bool contextIsValid = focus != null && focus.context != null;
if (contextIsValid) {
// Check for primary scrollable within the current context
// After https://github.com/dart-lang/language/issues/1274 is implemented,
// `focus` will be promoted to non-nullable so we won't need to null check
// it (and it will cause a build failure to try to do so). Until then, we
// need to null check it in a way that won't cause a build failure once
// the feature is implemented. We can do that using an explicit "if"
// test.
// TODO(paulberry): remove this hack once the feature is implemented.
if (focus == null) { // ignore: dead_code
throw 'This throw is unreachable';
}
if (Scrollable.of(focus.context!) != null)
return true;
// Check for fallback scrollable with context from PrimaryScrollController