From 176f7d71306ba7e17fe96f400d2e8e00cfb6f017 Mon Sep 17 00:00:00 2001 From: hellohuanlin <41930132+hellohuanlin@users.noreply.github.com> Date: Fri, 29 Jul 2022 23:36:09 -0700 Subject: [PATCH] [platform_view]run platform view ui test to physical device (#108642) --- .ci.yaml | 26 +++++++------------ TESTOWNERS | 2 +- .../native_platform_view_ui_tests_ios.dart | 1 + 3 files changed, 12 insertions(+), 17 deletions(-) diff --git a/.ci.yaml b/.ci.yaml index 90f6ff2ec5c..7d05bea1492 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -3350,6 +3350,16 @@ targets: ["devicelab", "ios", "mac"] task_name: microbenchmarks_ios + - name: Mac_ios native_platform_view_ui_tests_ios + bringup: true + recipe: devicelab/devicelab_drone + presubmit: false + timeout: 60 + properties: + tags: > + ["devicelab", "ios", "mac"] + task_name: native_platform_view_ui_tests_ios + - name: Mac_ios new_gallery_ios__transition_perf recipe: devicelab/devicelab_drone presubmit: false @@ -3485,22 +3495,6 @@ targets: - bin/** - .ci.yaml - - name: Mac native_platform_view_ui_tests_ios - bringup: true - recipe: devicelab/devicelab_drone - presubmit: false - timeout: 60 - properties: - dependencies: >- - [ - {"dependency": "android_sdk", "version": "version:32v1"}, - {"dependency": "open_jdk", "version": "11"}, - {"dependency": "xcode", "version": "13a233"} - ] - tags: > - ["devicelab", "hostonly"] - task_name: native_platform_view_ui_tests_ios - - name: Mac run_release_test_macos recipe: devicelab/devicelab_drone timeout: 60 diff --git a/TESTOWNERS b/TESTOWNERS index 2448db81787..57d61657c0f 100644 --- a/TESTOWNERS +++ b/TESTOWNERS @@ -174,6 +174,7 @@ /dev/devicelab/bin/tasks/large_image_changer_perf_ios.dart @zanderso @flutter/engine /dev/devicelab/bin/tasks/macos_chrome_dev_mode.dart @zanderso @flutter/tool /dev/devicelab/bin/tasks/microbenchmarks_ios.dart @zanderso @flutter/engine +/dev/devicelab/bin/tasks/native_platform_view_ui_tests_ios.dart @hellohuanlin @flutter/ios /dev/devicelab/bin/tasks/new_gallery_ios__transition_perf.dart @zanderso @flutter/engine /dev/devicelab/bin/tasks/new_gallery_impeller_ios__transition_perf.dart @zanderso @flutter/engine /dev/devicelab/bin/tasks/platform_channel_sample_test_ios.dart @zanderso @flutter/engine @@ -198,7 +199,6 @@ /dev/devicelab/bin/tasks/module_custom_host_app_name_test.dart @zanderso @flutter/tool /dev/devicelab/bin/tasks/module_host_with_custom_build_test.dart @zanderso @flutter/tool /dev/devicelab/bin/tasks/module_test.dart @zanderso @flutter/tool -/dev/devicelab/bin/tasks/native_platform_view_ui_tests_ios.dart @hellohuanlin @flutter/ios /dev/devicelab/bin/tasks/native_ui_tests_macos.dart @cbracken @flutter/desktop /dev/devicelab/bin/tasks/platform_channel_sample_test_windows.dart @cbracken @flutter/desktop /dev/devicelab/bin/tasks/plugin_test.dart @stuartmorgan @flutter/plugin diff --git a/dev/devicelab/bin/tasks/native_platform_view_ui_tests_ios.dart b/dev/devicelab/bin/tasks/native_platform_view_ui_tests_ios.dart index 40196efd8c3..8c4602c8686 100644 --- a/dev/devicelab/bin/tasks/native_platform_view_ui_tests_ios.dart +++ b/dev/devicelab/bin/tasks/native_platform_view_ui_tests_ios.dart @@ -10,6 +10,7 @@ import 'package:flutter_devicelab/framework/utils.dart'; import 'package:path/path.dart' as path; Future main() async { + deviceOperatingSystem = DeviceOperatingSystem.ios; await task(() async { final String projectDirectory = '${flutterDirectory.path}/dev/integration_tests/ios_platform_view_tests';