development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-08-25 02:46:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid applying partial dartfixes on CI (#143551)

Browse source 
Unblocks https://github.com/flutter/tests/pull/345

Add `bulkApply: false` to partial fixes so they don't automatically get applied on registered tests.
This commit is contained in:
LongCatIsLooong 2024-02-20 15:27:26 -08:00 committed by GitHub
parent 74a2e0d138
commit 174e58697c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/flutter/lib/fix_data/fix_material/fix_material.yaml
View file

@ -865,6 +865,7 @@ transforms:
# Changes made in https://github.com/flutter/flutter/pull/111706
- title: "Migrate to 'trackVisibility'"
date: 2022-09-15
bulkApply: false
element:
uris: [ 'material.dart' ]
field: 'showTrackOnHover'
@ -876,6 +877,7 @@ transforms:
# Changes made in https://github.com/flutter/flutter/pull/111706
- title: "Migrate to 'thumbVisibility'"
date: 2022-09-15
bulkApply: false
element:
uris: [ 'material.dart' ]
constructor: ''
@ -888,6 +890,7 @@ transforms:
# Changes made in https://github.com/flutter/flutter/pull/111706
- title: "Migrate to 'trackVisibility'"
date: 2022-09-15
bulkApply: false
element:
uris: [ 'material.dart' ]
method: 'copyWith'

7
packages/flutter/test_fixes/material/material.dart
View file

@ -304,9 +304,10 @@ void main() {
// Changes made in https://github.com/flutter/flutter/pull/111706
Scrollbar scrollbar = Scrollbar(showTrackOnHover: true);
bool nowShowing = scrollbar.showTrackOnHover;
ScrollbarThemeData scrollbarTheme = ScrollbarThemeData(showTrackOnHover: nowShowing);
scrollbarTheme.copyWith(showTrackOnHover: nowShowing);
scrollbarTheme.showTrackOnHover;
// The 3 expressions below have `bulkApply` set to true thus can't be tested yet.
//ScrollbarThemeData scrollbarTheme = ScrollbarThemeData(showTrackOnHover: nowShowing);
//scrollbarTheme.copyWith(showTrackOnHover: nowShowing);
//scrollbarTheme.showTrackOnHover;
// Changes made in https://github.com/flutter/flutter/pull/114459
MediaQuery.boldTextOverride(context);

7
packages/flutter/test_fixes/material/material.dart.expect
View file

@ -300,9 +300,10 @@ void main() {
// Changes made in https://github.com/flutter/flutter/pull/111706
Scrollbar scrollbar = Scrollbar(trackVisibility: true);
bool nowShowing = scrollbar.trackVisibility;
ScrollbarThemeData scrollbarTheme = ScrollbarThemeData(trackVisibility: nowShowing);
scrollbarTheme.copyWith(trackVisibility: nowShowing);
scrollbarTheme.trackVisibility;
// The 3 expressions below have `bulkApply` set to true thus can't be tested yet.
//ScrollbarThemeData scrollbarTheme = ScrollbarThemeData(showTrackOnHover: nowShowing);
//scrollbarTheme.copyWith(showTrackOnHover: nowShowing);
//scrollbarTheme.showTrackOnHover;
// Changes made in https://github.com/flutter/flutter/pull/114459
MediaQuery.boldTextOf(context);