From 169a4a0098146b8c78cdb654d5b42eccac67945f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20S=20Guerrero?= Date: Mon, 14 Mar 2022 12:30:20 -0700 Subject: [PATCH] Fix route integration test on ios (#99781) --- .ci.yaml | 4 +-- TESTOWNERS | 5 ++- dev/devicelab/bin/tasks/route_test_ios.dart | 35 +++++++++++++++++++++ 3 files changed, 39 insertions(+), 5 deletions(-) create mode 100644 dev/devicelab/bin/tasks/route_test_ios.dart diff --git a/.ci.yaml b/.ci.yaml index 132a36345db..9658debd580 100755 --- a/.ci.yaml +++ b/.ci.yaml @@ -3362,7 +3362,7 @@ targets: task_name: external_ui_integration_test_ios scheduler: luci - - name: Mac_ios routing_test + - name: Mac_ios route_test_ios bringup: true recipe: devicelab/devicelab_drone presubmit: false @@ -3370,7 +3370,7 @@ targets: properties: tags: > ["devicelab","ios","mac"] - task_name: routing_test + task_name: route_test_ios scheduler: luci - name: Mac_ios flavors_test_ios diff --git a/TESTOWNERS b/TESTOWNERS index afd22358677..f837edfd422 100644 --- a/TESTOWNERS +++ b/TESTOWNERS @@ -63,6 +63,7 @@ /dev/devicelab/bin/tasks/platform_channels_benchmarks.dart @gaaclarke @flutter/engine /dev/devicelab/bin/tasks/platform_views_scroll_perf__timeline_summary.dart @zanderso @flutter/engine /dev/devicelab/bin/tasks/plugin_dependencies_test.dart @jmagman @flutter/tool +/dev/devicelab/bin/tasks/routing_test.dart @zanderso @flutter/tool /dev/devicelab/bin/tasks/textfield_perf__e2e_summary.dart @zanderso @flutter/engine /dev/devicelab/bin/tasks/web_size__compile_test.dart @yjbanov @flutter/web /dev/devicelab/bin/tasks/opacity_peephole_col_of_rows_perf__e2e_summary.dart @flar @flutter/engine @@ -170,9 +171,7 @@ /dev/devicelab/bin/tasks/post_backdrop_filter_perf_ios__timeline_summary.dart @zanderso @flutter/engine /dev/devicelab/bin/tasks/simple_animation_perf_ios.dart @zanderso @flutter/engine /dev/devicelab/bin/tasks/tiles_scroll_perf_ios__timeline_summary.dart @zanderso @flutter/engine - -## Linux android and Mac iOS Devicelab tests -/dev/devicelab/bin/tasks/routing_test.dart @zanderso @flutter/tool +/dev/devicelab/bin/tasks/route_test_ios.dart @jasguerrero @flutter/tool ## Host only DeviceLab tests /dev/devicelab/bin/tasks/build_aar_module_test.dart @zanderso @flutter/tool diff --git a/dev/devicelab/bin/tasks/route_test_ios.dart b/dev/devicelab/bin/tasks/route_test_ios.dart new file mode 100644 index 00000000000..4ba3b42fc1d --- /dev/null +++ b/dev/devicelab/bin/tasks/route_test_ios.dart @@ -0,0 +1,35 @@ +// Copyright 2014 The Flutter Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +import 'dart:io'; + +import 'package:flutter_devicelab/framework/devices.dart'; +import 'package:flutter_devicelab/framework/framework.dart'; +import 'package:flutter_devicelab/framework/task_result.dart'; +import 'package:flutter_devicelab/framework/utils.dart'; +import 'package:path/path.dart' as path; + +void main() { + task(() async { + deviceOperatingSystem = DeviceOperatingSystem.ios; + final Device device = await devices.workingDevice; + await device.unlock(); + final Directory appDir = dir(path.join(flutterDirectory.path, 'dev/integration_tests/ui')); + section('TEST WHETHER `flutter drive --route` WORKS on IOS'); + await inDirectory(appDir, () async { + return flutter( + 'drive', + options: [ + '--verbose', + '-d', + device.deviceId, + '--route', + '/smuggle-it', + 'lib/route.dart', + ], + ); + }); + return TaskResult.success(null); + }); +}